jenkins-bot has submitted this change and it was merged.
Change subject: QA: Improve user page title selector for tests
......................................................................
QA: Improve user page title selector for tests
Pages on test2wiki have a ShortUrl as part of the title, so "I am on my
user page" in post_links.feature fails. This tightens up the selector
for page title. Test passes on test2wiki and still passes on ee-flow.
Bug: 67788
Change-Id: I4fe54d29689650b4dafd63dc77eae374029d27ec
---
M tests/browser/features/step_definitions/flow_steps.rb
M tests/browser/features/support/pages/user_page.rb
2 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/step_definitions/flow_steps.rb
b/tests/browser/features/step_definitions/flow_steps.rb
index 63a2936..8d64ca0 100644
--- a/tests/browser/features/step_definitions/flow_steps.rb
+++ b/tests/browser/features/step_definitions/flow_steps.rb
@@ -11,7 +11,7 @@
Then(/^I am on my user page$/) do
# Get the title of the page without '_' characters
text = 'User:' + ENV["MEDIAWIKI_USER"].sub(/_/, ' ')
- on(UserPage).first_heading_element.text.should == text
+ on(UserPage).page_title_element.text.should == text
end
Given(/^I am on a new board$/) do
diff --git a/tests/browser/features/support/pages/user_page.rb
b/tests/browser/features/support/pages/user_page.rb
index baf8b76..fbd143f 100644
--- a/tests/browser/features/support/pages/user_page.rb
+++ b/tests/browser/features/support/pages/user_page.rb
@@ -6,4 +6,8 @@
page_url URL.url("User talk:ENV['MEDIAWIKI_USER']")
h1(:first_heading, id: "firstHeading")
+ # on test2wiki, page titles include an additional ShortURL after span
containing page title.
+ span(:page_title) do |page|
+ page.first_heading_element.span_element(index: 0)
+ end
end
--
To view, visit https://gerrit.wikimedia.org/r/155494
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4fe54d29689650b4dafd63dc77eae374029d27ec
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Spage <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: SG <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
