Bsitu has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/155653

Change subject: Remove 'View Board' from all Flow notifications
......................................................................

Remove 'View Board' from all Flow notifications

This actually introduces a bug, since we remove all links
from "create new topic" notification, and notifications
in all notification page is not linked like the ones in
the flyout, the notification has no link at all.

Question is raised in the trello card

Change-Id: I4bb7349fea2d8675cd4db9b39c390c2ba4f6fc9a
---
M includes/Notifications/Notifications.php
1 file changed, 0 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/53/155653/1

diff --git a/includes/Notifications/Notifications.php 
b/includes/Notifications/Notifications.php
index 82fb936..66e6138 100644
--- a/includes/Notifications/Notifications.php
+++ b/includes/Notifications/Notifications.php
@@ -18,10 +18,6 @@
                        'message' => 'flow-notification-link-text-view-topic',
                        'destination' => 'flow-topic'
                ),
-               'secondary-link' => array(
-                       'message' => 'flow-notification-link-text-view-board',
-                       'destination' => 'flow-board'
-               ),
                'title-message' => 'flow-notification-newtopic',
                'title-params' => array( 'agent', 'flow-title', 'title', 
'subject', 'topic-permalink' ),
                'email-subject-message' => 
'flow-notification-newtopic-email-subject',
@@ -36,10 +32,6 @@
                'primary-link' => array(
                        'message' => 'flow-notification-link-text-view-post',
                        'destination' => 'flow-post'
-               ),
-               'secondary-link' => array(
-                       'message' => 'flow-notification-link-text-view-board',
-                       'destination' => 'flow-board'
                ),
                'title-message' => 'flow-notification-reply',
                'title-params' => array( 'agent', 'subject', 'flow-title', 
'title', 'post-permalink' ),
@@ -61,10 +53,6 @@
                        'message' => 'flow-notification-link-text-view-post',
                        'destination' => 'flow-post'
                ),
-               'secondary-link' => array(
-                       'message' => 'flow-notification-link-text-view-board',
-                       'destination' => 'flow-board'
-               ),
                'title-message' => 'flow-notification-edit',
                'title-params' => array( 'agent', 'subject', 'flow-title', 
'title', 'post-permalink' ),
                'bundle' => array(
@@ -85,10 +73,6 @@
                        'message' => 'flow-notification-link-text-view-post',
                        'destination' => 'flow-post'
                ),
-               'secondary-link' => array(
-                       'message' => 'flow-notification-link-text-view-board',
-                       'destination' => 'flow-board'
-               ),
                'title-message' => 'flow-notification-rename',
                'title-params' => array( 'agent', 'topic-permalink', 
'old-subject', 'new-subject', 'flow-title', 'title' ),
                'email-subject-message' => 
'flow-notification-rename-email-subject',
@@ -100,10 +84,6 @@
                'primary-link' => array(
                        'message' => 'notification-link-text-view-mention',
                        'destination' => 'flow-post'
-               ),
-               'secondary-link' => array(
-                       'message' => 'flow-notification-link-text-view-board',
-                       'destination' => 'flow-board'
                ),
                'category' => 'mention',
                'title-message' => 'flow-notification-mention',

-- 
To view, visit https://gerrit.wikimedia.org/r/155653
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4bb7349fea2d8675cd4db9b39c390c2ba4f6fc9a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Bsitu <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to