jenkins-bot has submitted this change and it was merged.
Change subject: Remove server-side signup experiment event logging
......................................................................
Remove server-side signup experiment event logging
Stop logging the following events:
* TrackedPageContentSaveComplete
* SignupExpAccountCreationComplete
* SignupExpAccountCreationImpression
Also, remove the associated GettingStarted\Hooks::getGettingStartedToken
method.
Change-Id: I69f4c643841df78622943eba1882fd21611726e3
---
M GettingStarted.php
M Hooks.php
2 files changed, 0 insertions(+), 87 deletions(-)
Approvals:
Robmoen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/GettingStarted.php b/GettingStarted.php
index 0ba0219..c1c012a 100644
--- a/GettingStarted.php
+++ b/GettingStarted.php
@@ -432,9 +432,6 @@
$wgHooks[ 'GetPreferences' ][] = 'GettingStarted\Hooks::onGetPreferences';
$wgHooks[ 'UserLogoutComplete'][] =
'GettingStarted\Hooks::onUserLogoutComplete';
$wgHooks[ 'ResourceLoaderTestModules' ][] =
'GettingStarted\Hooks::onResourceLoaderTestModules';
-$wgHooks[ 'PageContentSaveComplete' ][] =
'GettingStarted\Hooks::onPageContentSaveComplete';
-$wgHooks[ 'AddNewAccount' ][] = 'GettingStarted\Hooks::onAddNewAccount';
-$wgHooks[ 'UserCreateForm' ][] = 'GettingStarted\Hooks::onUserCreateForm';
$wgHooks[ 'PersonalUrls' ][] = 'GettingStarted\Hooks::onPersonalUrls';
$wgExtensionFunctions[] = 'GettingStarted\Hooks::onSetup';
diff --git a/Hooks.php b/Hooks.php
index a76776e..0af448b 100644
--- a/Hooks.php
+++ b/Hooks.php
@@ -124,15 +124,6 @@
}
/**
- * Gets the getting started user token
- * @return string or null
- */
- protected static function getGettingStartedToken() {
- global $wgRequest;
- return $wgRequest->getCookie( self::USER_TOKEN_COOKIE_NAME );
- }
-
- /**
* Checks if the task toolbar should be loaded.
*
* It will load if it's a view of an existing page, and the user's
browser
@@ -488,34 +479,6 @@
}
/**
- * Log server-side event on successful page edit.
- * @see
https://www.mediawiki.org/wiki/Manual:Hooks/PageContentSaveComplete
- * @see
https://meta.wikimedia.org/wiki/Schema:TrackedPageContentSaveComplete
- */
- public static function onPageContentSaveComplete( $article, $user,
$content, $summary,
- $isMinor, $isWatch, $section, $flags, $revision, $status,
$baseRevId ) {
-
- global $wgRequest;
-
- if ( $revision === null ) {
- return true;
- }
-
- $revId = $revision->getId();
- $event = array(
- 'revId' => $revId,
- );
-
- $gettingStartedToken = self::getGettingStartedToken();
- if ( $gettingStartedToken !== null ) {
- $event['token'] = $gettingStartedToken;
- }
-
- \EventLogging::logEvent( 'TrackedPageContentSaveComplete',
8535426, $event );
- return true;
- }
-
- /**
* If the site is a Wikipedia, this is called to specify that
Wikipedia-specific
* versions will be used for certain keys.
*
@@ -547,53 +510,6 @@
) ) ) {
$lckey = "{$lckey}-wikipedia";
}
-
- return true;
- }
-
- /**
- * Logs a successful account creation, including the token
- *
- * @param User $user Newly created user
- * @param boolean $byEmail True if and only if created by email
- *
- * @return bool Always true
- */
- public static function onAddNewAccount( User $user, $byEmail ) {
- $gettingStartedToken = self::getGettingStartedToken();
-
- $event = array(
- 'userId' => $user->getId()
- );
-
- if ( $gettingStartedToken !== null ) {
- $event['token'] = $gettingStartedToken;
- }
-
- \EventLogging::logEvent( 'SignupExpAccountCreationComplete',
8539421, $event );
-
- return true;
- }
-
- /**
- * Logs an impression on the signup form
- *
- * @param &$template Template for form (unused)
- *
- * @return bool Always true
- */
- public static function onUserCreateForm( &$template ) {
- $gettingStartedToken = self::getGettingStartedToken();
-
- $event = array();
-
- if ( $gettingStartedToken !== null ) {
- $event['token'] = $gettingStartedToken;
- }
-
- // Cast so it's not serialized to []; temporary workaround for
- // https://bugzilla.wikimedia.org/show_bug.cgi?id=65385 .
- \EventLogging::logEvent( 'SignupExpAccountCreationImpression',
8539445, (object) $event );
return true;
}
--
To view, visit https://gerrit.wikimedia.org/r/155713
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I69f4c643841df78622943eba1882fd21611726e3
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: master
Gerrit-Owner: Phuedx <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Robmoen <[email protected]>
Gerrit-Reviewer: Swalling <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
