Jeroen De Dauw has submitted this change and it was merged.
Change subject: Attempt to fix bug 70041
......................................................................
Attempt to fix bug 70041
Change-Id: Ib997a2bb6ffd10e4b51cc1b7ce5e793b83a0c93d
---
M repo/tests/phpunit/includes/api/RemoveClaimsTest.php
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
WikidataJenkins: Verified
Thiemo Mättig (WMDE): Looks good to me, approved
jenkins-bot: Checked
diff --git a/repo/tests/phpunit/includes/api/RemoveClaimsTest.php
b/repo/tests/phpunit/includes/api/RemoveClaimsTest.php
index a109771..f1a5227 100644
--- a/repo/tests/phpunit/includes/api/RemoveClaimsTest.php
+++ b/repo/tests/phpunit/includes/api/RemoveClaimsTest.php
@@ -89,6 +89,8 @@
* @param Entity $entity
*/
public function doTestValidRequestSingle( Entity $entity ) {
+ $obtainedClaims = null;
+
/**
* @var Claim[] $claims
*/
@@ -106,7 +108,7 @@
$this->assertTrue( $obtainedClaims->getHash() ===
$currentClaims->getHash() );
}
- $this->assertTrue( $obtainedClaims->isEmpty() );
+ $this->assertTrue( $obtainedClaims === null ||
$obtainedClaims->isEmpty() );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/156296
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib997a2bb6ffd10e4b51cc1b7ce5e793b83a0c93d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: WikidataJenkins <wikidata-servi...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
