jenkins-bot has submitted this change and it was merged.
Change subject: Fallback to master lookup for title when lookup in slave fails
......................................................................
Fallback to master lookup for title when lookup in slave fails
Bug: 69913
Change-Id: I5d6a4ec750dc8438c92c9e70c36554ff7dbc97f1
---
M model/Notification.php
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
EBernhardson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/model/Notification.php b/model/Notification.php
index d502770..a0f808b 100644
--- a/model/Notification.php
+++ b/model/Notification.php
@@ -135,8 +135,13 @@
$user = $this->user;
if ( $event->getExtraParam( 'target-page' ) ) {
$notifMapper->attachListener( 'insert',
'add-target-page', function() use ( $event, $user, $eventIds ) {
+ $targetPageId = $event->getExtraParam(
'target-page' );
// Make sure the target-page id is a valid id
- $title = Title::newFromID(
$event->getExtraParam( 'target-page' ) );
+ $title = Title::newFromID( $targetPageId );
+ // Try master if there is no match
+ if ( !$title ) {
+ $title = Title::newFromID(
$targetPageId, Title::GAID_FOR_UPDATE );
+ }
if ( $title ) {
$targetMapper = new
EchoTargetPageMapper();
if ( $eventIds ) {
--
To view, visit https://gerrit.wikimedia.org/r/156466
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d6a4ec750dc8438c92c9e70c36554ff7dbc97f1
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Bsitu <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
