Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/156723
Change subject: Fix various bugs in our Monobook stylesheet
......................................................................
Fix various bugs in our Monobook stylesheet
* Toolbar was too tall
** The actions toolbar is nested in the main toolbar, so the rule
increasing the font size by 25% for toolbars applied to it twice
* Font size in link suggestions was too big
** Remove 25% font size increase from overlays
** Add it back on the context (otherwise it's too small)
** But only on the main surface's context (otherwise contexts in dialogs are
too big)
* Make highlights and context appear below, not above, toolbar menus
** z-index: 4 was too high for the overlay, because menuToolGroup also has 4
** But the default of z-index: 1 is too low because it puts dialogs behind the
surface
** z-index: 2 seems to work
Bug: 69949
Change-Id: I19da270abcdbe526ff213f0eb7d0859b48276930
---
M modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget-monobook.css
1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/23/156723/1
diff --git a/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget-monobook.css
b/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget-monobook.css
index e00d304..c819c23 100644
--- a/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget-monobook.css
+++ b/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget-monobook.css
@@ -9,17 +9,17 @@
margin: -0.6em -0.8em 1em -0.8em;
}
-.oo-ui-toolbar {
+/* Correct for Monobook's small font in toolbars and contexts, but beware:
+ * - Only apply this to the outer toolbar, not the inner toolbar (otherwise
it multiplies)
+ * - Only apply this to the main surface's context, not inside dialogs (they
have their own
+ * font size fixes)
+ */
+.ve-init-mw-viewPageTarget-toolbar,
+.ve-init-mw-viewPageTarget-surface .ve-ui-context {
font-size: 1.25em;
line-height: 1.5em;
}
-/* Monobook sets font-size: x-small; on the body. Undo this in frames and
overlays */
-.oo-ui-frame-body,
-body .ve-ui-overlay {
- font-size: medium;
-}
-
.ve-ui-overlay {
- z-index: 4;
+ z-index: 2;
}
--
To view, visit https://gerrit.wikimedia.org/r/156723
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I19da270abcdbe526ff213f0eb7d0859b48276930
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
