Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/156965
Change subject: Return undefined, not null from onbeforeunload
......................................................................
Return undefined, not null from onbeforeunload
IE doesn't accept null as a "do nothing" value, only undefined.
If you return null, it'll show a popup with the text "null".
Change-Id: I984a7ded483c4c178cbca2a9af9abd895e6ded56
---
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/65/156965/1
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
index 6742cc4..5b92038 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
@@ -1618,7 +1618,7 @@
};
/**
- * Add onbeforunload handler.
+ * Add onbeforeunload handler.
*
* @method
*/
@@ -1726,7 +1726,7 @@
} else {
// Override if submitting
if ( this.submitting ) {
- return null;
+ return undefined;
}
// Check if there's been an edit
if ( this.surface && this.edited && mw.user.options.get(
'useeditwarning' ) ) {
--
To view, visit https://gerrit.wikimedia.org/r/156965
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I984a7ded483c4c178cbca2a9af9abd895e6ded56
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
