Jeroen De Dauw has submitted this change and it was merged.
Change subject: Remove wfSuppressWarnings
......................................................................
Remove wfSuppressWarnings
Change-Id: Ic3fefd2c4e10df1c8540312371809a02922837fc
---
M repo/tests/phpunit/includes/api/GetClaimsTest.php
M repo/tests/phpunit/includes/api/RemoveQualifiersTest.php
M repo/tests/phpunit/includes/api/RemoveReferencesTest.php
3 files changed, 0 insertions(+), 6 deletions(-)
Approvals:
Jeroen De Dauw: Looks good to me, approved
diff --git a/repo/tests/phpunit/includes/api/GetClaimsTest.php
b/repo/tests/phpunit/includes/api/GetClaimsTest.php
index 2c6841d..1006552 100644
--- a/repo/tests/phpunit/includes/api/GetClaimsTest.php
+++ b/repo/tests/phpunit/includes/api/GetClaimsTest.php
@@ -71,9 +71,7 @@
$item->addClaim( $statement );
}
- wfSuppressWarnings(); // We are referencing properties that
don't exist. Not relevant here.
$this->save( $item, EDIT_UPDATE );
- wfRestoreWarnings();
return $item;
}
diff --git a/repo/tests/phpunit/includes/api/RemoveQualifiersTest.php
b/repo/tests/phpunit/includes/api/RemoveQualifiersTest.php
index 8974030..0fdeadd 100644
--- a/repo/tests/phpunit/includes/api/RemoveQualifiersTest.php
+++ b/repo/tests/phpunit/includes/api/RemoveQualifiersTest.php
@@ -76,7 +76,6 @@
foreach ( $this->statementProvider() as $statement ) {
$item = Item::newEmpty();
- wfSuppressWarnings(); // We are referencing properties
that don't exist. Not relevant here.
$store->saveEntity( $item, '', $GLOBALS['wgUser'],
EDIT_NEW );
$guidGenerator = new ClaimGuidGenerator();
@@ -84,7 +83,6 @@
$item->addClaim( $statement );
$store->saveEntity( $item, '', $GLOBALS['wgUser'],
EDIT_UPDATE );
- wfRestoreWarnings();
$this->assertInternalType( 'string',
$statement->getGuid() );
diff --git a/repo/tests/phpunit/includes/api/RemoveReferencesTest.php
b/repo/tests/phpunit/includes/api/RemoveReferencesTest.php
index 5e4651e..56e8c91 100644
--- a/repo/tests/phpunit/includes/api/RemoveReferencesTest.php
+++ b/repo/tests/phpunit/includes/api/RemoveReferencesTest.php
@@ -75,7 +75,6 @@
foreach ( $this->statementProvider() as $statement ) {
$item = Item::newEmpty();
- wfSuppressWarnings(); // We are referencing properties
that don't exist. Not relevant here.
$store =
WikibaseRepo::getDefaultInstance()->getEntityStore();
$store->saveEntity( $item, '', $GLOBALS['wgUser'],
EDIT_NEW );
@@ -84,7 +83,6 @@
$item->addClaim( $statement );
$store->saveEntity( $item, '', $GLOBALS['wgUser'],
EDIT_UPDATE );
- wfRestoreWarnings();
$references = $statement->getReferences();
--
To view, visit https://gerrit.wikimedia.org/r/157134
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3fefd2c4e10df1c8540312371809a02922837fc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
