Jeroen De Dauw has submitted this change and it was merged.

Change subject: Fix SetSiteLinkTest
......................................................................


Fix SetSiteLinkTest

Change-Id: Ie8934df2da349cd25e94c2825ce4368cf98731ec
---
M repo/tests/phpunit/includes/api/SetSiteLinkTest.php
1 file changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Jeroen De Dauw: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/repo/tests/phpunit/includes/api/SetSiteLinkTest.php 
b/repo/tests/phpunit/includes/api/SetSiteLinkTest.php
index b137639..8a73e03 100644
--- a/repo/tests/phpunit/includes/api/SetSiteLinkTest.php
+++ b/repo/tests/phpunit/includes/api/SetSiteLinkTest.php
@@ -254,9 +254,7 @@
                        );
 
                        $this->assertArrayHasKey( 'badges', $sitelink );
-                       $this->assertArrayEquals( $expSitelink['badges'], 
$sitelink['badges'],
-                               "Returned incorrect badges"
-                       );
+                       $this->assertArrayEquals( $expSitelink['badges'], 
$sitelink['badges'] );
                } else if ( empty( $expected['value'] ) ) {
                        $this->assertArrayHasKey( 'removed', $sitelink,
                                "Entity doesn't return expected 'removed' 
marker"
@@ -342,5 +340,5 @@
                $warning = $result['warnings']['wbsetsitelink']['*'];
                $this->assertRegExp( "/Unrecognized value for parameter 
'badges'/", $warning );
        }
-}
 
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/157147
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8934df2da349cd25e94c2825ce4368cf98731ec
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to