Jeroen De Dauw has submitted this change and it was merged. Change subject: Make SnaksFinderTest compatible to DataModel 1.0 ......................................................................
Make SnaksFinderTest compatible to DataModel 1.0 Change-Id: Iaae8e43ae6e37deddc0d12da5d36be9f9ffc7510 --- M client/tests/phpunit/includes/DataAccess/PropertyParserFunction/SnaksFinderTest.php 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: Jeroen De Dauw: Looks good to me, approved diff --git a/client/tests/phpunit/includes/DataAccess/PropertyParserFunction/SnaksFinderTest.php b/client/tests/phpunit/includes/DataAccess/PropertyParserFunction/SnaksFinderTest.php index 1c60c60..7a0699b 100644 --- a/client/tests/phpunit/includes/DataAccess/PropertyParserFunction/SnaksFinderTest.php +++ b/client/tests/phpunit/includes/DataAccess/PropertyParserFunction/SnaksFinderTest.php @@ -39,31 +39,31 @@ $entityLookup = new MockRepository(); - $claim1 = new Claim( new PropertyValueSnak( + $statement1 = new Statement( new PropertyValueSnak( $propertyId, new StringValue( 'a kitten!' ) ) ); - $claim1->setGuid( 'Q42$1' ); + $statement1->setGuid( 'Q42$1' ); - $claim2 = new Claim( new PropertyValueSnak( + $statement2 = new Statement( new PropertyValueSnak( $propertyId, new StringValue( 'two kittens!!' ) ) ); - $claim2->setGuid( 'Q42$2' ); + $statement2->setGuid( 'Q42$2' ); // A Statement with a lower rank which should not affect the output - $claim3 = new Statement( new PropertyValueSnak( + $statement3 = new Statement( new PropertyValueSnak( $propertyId, new StringValue( 'three kittens!!!' ) ) ); - $claim3->setGuid( 'Q42$3' ); - $claim3->setRank( Claim::RANK_NORMAL ); + $statement3->setGuid( 'Q42$3' ); + $statement3->setRank( Claim::RANK_DEPRECATED ); $item = Item::newEmpty(); $item->setId( new ItemId( 'Q42' ) ); - $item->addClaim( $claim1 ); - $item->addClaim( $claim2 ); - $item->addClaim( $claim3 ); + $item->addClaim( $statement1 ); + $item->addClaim( $statement2 ); + $item->addClaim( $statement3 ); $property = Property::newFromType( 'string' ); $property->setId( $propertyId ); -- To view, visit https://gerrit.wikimedia.org/r/157647 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaae8e43ae6e37deddc0d12da5d36be9f9ffc7510 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits