Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/157864
Change subject: Don't hardcode that templates are never disambiguation pages
......................................................................
Don't hardcode that templates are never disambiguation pages
There's no reason why they couldn't be, and this makes extending this
code harder. If they're not supposed to, then that should be solved
on-wiki by wrapping the __DISAMBIG__ in <includeonly/>.
Change-Id: I20ad2e20301cb32733f510662c2d173cfbda869a
---
M Disambiguator.hooks.php
M specials/SpecialDisambiguationPages.php
2 files changed, 0 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Disambiguator
refs/changes/64/157864/1
diff --git a/Disambiguator.hooks.php b/Disambiguator.hooks.php
index bffc3d9..1fb80db 100644
--- a/Disambiguator.hooks.php
+++ b/Disambiguator.hooks.php
@@ -51,11 +51,6 @@
*/
public static function isDisambiguationPage( Title $title ) {
wfProfileIn( __METHOD__ );
- // Exclude disambiguation templates
- if ( $title->getNamespace() === NS_TEMPLATE ) {
- wfProfileOut( __METHOD__ );
- return false;
- }
$pageId = $title->getArticleID();
if ( $pageId ) {
$dbr = wfGetDB( DB_SLAVE );
diff --git a/specials/SpecialDisambiguationPages.php
b/specials/SpecialDisambiguationPages.php
index 96e45ac..39bd26b 100644
--- a/specials/SpecialDisambiguationPages.php
+++ b/specials/SpecialDisambiguationPages.php
@@ -38,8 +38,6 @@
'conds' => array(
'page_id = pp_page',
'pp_propname' => 'disambiguation',
- // Exclude disambiguation templates
- 'page_namespace != ' . NS_TEMPLATE
)
);
}
--
To view, visit https://gerrit.wikimedia.org/r/157864
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I20ad2e20301cb32733f510662c2d173cfbda869a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Disambiguator
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
