Mattflaschen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/158850
Change subject: Sort modules in alphabetical order and leave note about this
......................................................................
Sort modules in alphabetical order and leave note about this
This ensures the rendering matches what would happen if they were
used together with addModuleStyles, which is the way these modules
are generally used.
Change-Id: I1d6f0f41dc9ac4782a4c5891354b0e323a6161b5
---
M docs/kss/Makefile
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/50/158850/1
diff --git a/docs/kss/Makefile b/docs/kss/Makefile
index ff735d5..a7b0c47 100644
--- a/docs/kss/Makefile
+++ b/docs/kss/Makefile
@@ -4,7 +4,9 @@
# Generates CSS of mediawiki.ui and mediawiki.ui.button using ResourceLoader,
then applies it to the
# KSS style guide
$(eval KSS_RL_TMP := $(shell mktemp /tmp/tmp.XXXXXXXXXX))
- @curl -sG
"${MEDIAWIKI_LOAD_URL}?modules=mediawiki.ui.anchor|mediawiki.ui.checkbox|mediawiki.ui.input|mediawiki.legacy.shared|mediawiki.legacy.commonPrint|mediawiki.ui|mediawiki.ui.button&only=styles"
> $(KSS_RL_TMP)
+# Keep module names in strict alphabetical order, so CSS loads in the same
order as ResourceLoader's addModuleStyles does; this can affect rendering.
+# See OutputPage::makeResourceLoaderLink.
+ @curl -sG
"${MEDIAWIKI_LOAD_URL}?modules=mediawiki.legacy.commonPrint|mediawiki.legacy.shared|mediawiki.ui|mediawiki.ui.anchor|mediawiki.ui.button|mediawiki.ui.checkbox|mediawiki.ui.input&only=styles"
> $(KSS_RL_TMP)
@node_modules/.bin/kss-node ../../resources/src/mediawiki.ui static/
--css $(KSS_RL_TMP) -t styleguide-template
@rm $(KSS_RL_TMP)
--
To view, visit https://gerrit.wikimedia.org/r/158850
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d6f0f41dc9ac4782a4c5891354b0e323a6161b5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
