jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: Give ApiStub modes names instead of numbers
......................................................................
Hygiene: Give ApiStub modes names instead of numbers
Change-Id: Ia01ba14a1b2ab179454f14e5a1595ff468c46fc5
---
M tests/qunit/overlay/test_ext.echo.overlay.js
1 file changed, 9 insertions(+), 9 deletions(-)
Approvals:
EBernhardson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/qunit/overlay/test_ext.echo.overlay.js
b/tests/qunit/overlay/test_ext.echo.overlay.js
index 1c58e43..b255915 100644
--- a/tests/qunit/overlay/test_ext.echo.overlay.js
+++ b/tests/qunit/overlay/test_ext.echo.overlay.js
@@ -18,7 +18,7 @@
var i, id,
index = [], listObj = {},
data = this.getData();
- if ( this.mode === 1 ) {
+ if ( this.mode === 'no-new-messages' ) {
data.query.notifications.message = {
index: [ 100 ],
list: {
@@ -33,7 +33,7 @@
rawcount: 0,
count: '0'
};
- } else if ( this.mode === 2 ) {
+ } else if ( this.mode ===
'with-new-messages' ) {
for ( i = 0; i < 7; i++ ) {
id = 500 + i;
index.push( id );
@@ -160,7 +160,7 @@
QUnit.test( 'mw.echo.overlay.buildOverlay with messages', 5, function(
assert ) {
var $overlay;
- this.sandbox.stub( mw.echo.overlay, 'api', new this.ApiStub( 1
) );
+ this.sandbox.stub( mw.echo.overlay, 'api', new this.ApiStub(
'no-new-messages' ) );
mw.echo.overlay.buildOverlay( function( $o ) {
$overlay = $o;
} );
@@ -177,7 +177,7 @@
QUnit.test( 'Switch tabs on overlay. No unread messages, 1 unread
alert.', 4, function( assert ) {
var $overlay, $tabs;
- this.sandbox.stub( mw.echo.overlay, 'api', new this.ApiStub( 1
) );
+ this.sandbox.stub( mw.echo.overlay, 'api', new this.ApiStub(
'no-new-messages' ) );
mw.echo.overlay.buildOverlay( function( $o ) {
$overlay = $o;
$tabs = $overlay.find( '.mw-echo-overlay-title li a' );
@@ -199,7 +199,7 @@
QUnit.test( 'Tabs have labels with counts in them.', 4, function(
assert ) {
var $overlay, $tabs, beforeAlertText, afterAlertText;
- this.sandbox.stub( mw.echo.overlay, 'api', new this.ApiStub( 1
) );
+ this.sandbox.stub( mw.echo.overlay, 'api', new this.ApiStub(
'no-new-messages' ) );
mw.echo.overlay.buildOverlay( function( $o ) {
$overlay = $o;
$tabs = $overlay.find( '.mw-echo-overlay-title li a' );
@@ -220,7 +220,7 @@
QUnit.test( 'Unread message behaviour', 5, function( assert ) {
var $overlay;
- this.sandbox.stub( mw.echo.overlay, 'api', new this.ApiStub( 2
) );
+ this.sandbox.stub( mw.echo.overlay, 'api', new this.ApiStub(
'with-new-messages' ) );
mw.echo.overlay.buildOverlay( function( $o ) {
$overlay = $o;
} );
@@ -243,7 +243,7 @@
QUnit.test( 'Mark as read.', 8, function( assert ) {
var $overlay;
this.$badge.text( '8' );
- this.sandbox.stub( mw.echo.overlay, 'api', new this.ApiStub( 2
) );
+ this.sandbox.stub( mw.echo.overlay, 'api', new this.ApiStub(
'with-new-messages' ) );
mw.echo.overlay.buildOverlay( function( $o ) {
$overlay = $o;
} );
@@ -269,7 +269,7 @@
QUnit.test( 'Tabs when there is overflow.', 2, function( assert ) {
var $overlay;
- this.sandbox.stub( mw.echo.overlay, 'api', new this.ApiStub( 2,
50 ) );
+ this.sandbox.stub( mw.echo.overlay, 'api', new this.ApiStub(
'with-new-messages', 50 ) );
mw.echo.overlay.buildOverlay( function( $o ) {
$overlay = $o;
} );
@@ -283,7 +283,7 @@
QUnit.test( 'Switching tabs visibility', 4, function( assert ) {
var $overlay;
- this.sandbox.stub( mw.echo.overlay, 'api', new this.ApiStub( 2
) );
+ this.sandbox.stub( mw.echo.overlay, 'api', new this.ApiStub(
'with-new-messages' ) );
mw.echo.overlay.buildOverlay( function( $o ) {
// put in dom so we can do visibility tests
$overlay = $o.appendTo( '#qunit-fixture' );
--
To view, visit https://gerrit.wikimedia.org/r/158826
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia01ba14a1b2ab179454f14e5a1595ff468c46fc5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
