jenkins-bot has submitted this change and it was merged.
Change subject: Use $.ready and $.when instead of nesting callbacks
......................................................................
Use $.ready and $.when instead of nesting callbacks
Follows-up I0278575038.
Change-Id: I12fc8d717d812cfa57784e2e1b0a52861f157452
---
M resources/ext.wikiLove.init.js
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/ext.wikiLove.init.js b/resources/ext.wikiLove.init.js
index 9dc6d29..ee5f935 100644
--- a/resources/ext.wikiLove.init.js
+++ b/resources/ext.wikiLove.init.js
@@ -1,5 +1,6 @@
( function ( $, mw ) {
- mw.loader.using( 'ext.wikiLove.local', function () {
- $( $.wikiLove.init );
- } );
+ $.when(
+ mw.loader.using( 'ext.wikiLove.local' ),
+ $.ready
+ ).done( $.wikiLove.init );
} )( jQuery, mediaWiki );
--
To view, visit https://gerrit.wikimedia.org/r/159084
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I12fc8d717d812cfa57784e2e1b0a52861f157452
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/WikiLove
Gerrit-Branch: master
Gerrit-Owner: Helder.wiki <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
