jenkins-bot has submitted this change and it was merged. Change subject: QA: Fix missing "Given I am logged in as a new user" ......................................................................
QA: Fix missing "Given I am logged in as a new user" Echo browser tests pass, but are skipping Scenario: New user gets a sign up notification because a step definition is missing. I simply adapted ^I am logged in as a new user with no notifications$ and the scenario passes in chrome. Change-Id: I9f2bd10d05b689eaacbf2890913786eb157d6af9 --- M tests/browser/features/step_definitions/notifications_steps.rb 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jdlrobson: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/browser/features/step_definitions/notifications_steps.rb b/tests/browser/features/step_definitions/notifications_steps.rb index b68c5f3..f7b0ea5 100644 --- a/tests/browser/features/step_definitions/notifications_steps.rb +++ b/tests/browser/features/step_definitions/notifications_steps.rb @@ -51,6 +51,11 @@ make_page_with_user_b(title, text) end +Given(/^I am logged in as a new user$/) do + @username = get_new_username() + step 'I am logged in as the user "' + @username + '"' +end + Given(/^I am logged in as a new user with no notifications$/) do @username = get_new_username() clear_notifications( @username ) -- To view, visit https://gerrit.wikimedia.org/r/159022 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f2bd10d05b689eaacbf2890913786eb157d6af9 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Echo Gerrit-Branch: master Gerrit-Owner: Spage <[email protected]> Gerrit-Reviewer: Bsitu <[email protected]> Gerrit-Reviewer: Jdlrobson <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
