jenkins-bot has submitted this change and it was merged.
Change subject: Use invalid UnDeserializableValue in
DataModelSerializationRoundtripTest
......................................................................
Use invalid UnDeserializableValue in DataModelSerializationRoundtripTest
instead of value => 'a string!', type => 'string' which can be deserialized
back into StringValue, use type => 'time' so we can verify this comes
back correctly as UnDeserializableValue in the roundtrip tests.
also add @group Wikibase to DataModelSerializationRoundtripTest so
that the tests actually run on jenkins and travis!
Change-Id: Ifc8892cf313c63d7c76036d2ebf069c438add481
---
M lib/tests/phpunit/serializers/DataModelSerializationRoundtripTest.php
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Daniel Kinzler: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/lib/tests/phpunit/serializers/DataModelSerializationRoundtripTest.php
b/lib/tests/phpunit/serializers/DataModelSerializationRoundtripTest.php
index 06807e1..6cce7f6 100644
--- a/lib/tests/phpunit/serializers/DataModelSerializationRoundtripTest.php
+++ b/lib/tests/phpunit/serializers/DataModelSerializationRoundtripTest.php
@@ -31,6 +31,8 @@
/**
* @todo Add tests with $options->setIndexTags( true ).
*
+ * @group Wikibase
+ *
* @licence GNU GPL v2+
* @author Thiemo Mättig
*/
@@ -222,7 +224,7 @@
),
new PropertyValueSnak(
new PropertyId( $baseId . '5' ),
- new UnDeserializableValue(
'undeserializable-data', 'string', 'error' )
+ new UnDeserializableValue(
'undeserializable-data', 'time', 'array expected' )
),
new PropertyValueSnak(
new PropertyId( $baseId . '6' ),
--
To view, visit https://gerrit.wikimedia.org/r/159029
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc8892cf313c63d7c76036d2ebf069c438add481
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: Tpt <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
