Jeroen De Dauw has submitted this change and it was merged.
Change subject: Fix fatal in EntityContent::getTextForFilters
......................................................................
Fix fatal in EntityContent::getTextForFilters
@note there should be a follow up that perhaps extracts this
functionality and ensures it is covered by tests.
Bug: 70725
Change-Id: I1ad7212401d915ce2878853b6b3969333f9b7a1a
---
M repo/includes/content/EntityContent.php
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Jeroen De Dauw: Looks good to me, approved
diff --git a/repo/includes/content/EntityContent.php
b/repo/includes/content/EntityContent.php
index 12ae29a..f344303 100644
--- a/repo/includes/content/EntityContent.php
+++ b/repo/includes/content/EntityContent.php
@@ -414,7 +414,9 @@
'type',
);
- $data = $this->getEntity()->toArray();
+ // @todo this text for filters stuff should be it's own class
with test coverage!
+ $codec =
WikibaseRepo::getDefaultInstance()->getEntityContentDataCodec();
+ $data = json_decode( $codec->encodeEntity( $this->getEntity()
), true );
$values = self::collectValues( $data, $ignore );
--
To view, visit https://gerrit.wikimedia.org/r/159797
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ad7212401d915ce2878853b6b3969333f9b7a1a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
