Brion VIBBER has submitted this change and it was merged. Change subject: Updates to icons and splash images for new screen sizes. ......................................................................
Updates to icons and splash images for new screen sizes. Change-Id: Id5845776be390f61351e06117c0887f1a9532d1f --- M Wikipedia.xcodeproj/project.pbxproj A scripts/icon-svgs-to-pngs.sh M wikipedia/AppDelegate.m M wikipedia/Fonts/makeFontFromSvgs.py M wikipedia/Fonts/makeSvgsFromFont.py M wikipedia/Images.xcassets/AppIcon.appiconset/Contents.json R wikipedia/Images.xcassets/AppIcon.appiconset/icon.svg A wikipedia/Images.xcassets/AppIcon.appiconset/icon120-1.png A wikipedia/Images.xcassets/AppIcon.appiconset/icon180-1.png A wikipedia/Images.xcassets/AppIcon.appiconset/icon180.png A wikipedia/Images.xcassets/AppIcon.appiconset/icon87-1.png A wikipedia/Images.xcassets/AppIcon.appiconset/icon87.png A wikipedia/Images.xcassets/AppIcon.appiconset/icon90.png D wikipedia/Images.xcassets/AppIcon.appiconset/svg and notes/notes.txt M wikipedia/Images.xcassets/LaunchImage.launchimage/splash_1242x2208-1.png M wikipedia/Images.xcassets/LaunchImage.launchimage/splash_2208x1242-1.png M wikipedia/Images.xcassets/LaunchImage.launchimage/splash_750x1334-1.png M wikipedia/Images.xcassets/RecentPagesEmpty.imageset/Contents.json R wikipedia/Images.xcassets/RecentPagesEmpty.imageset/recent.svg A wikipedia/Images.xcassets/RecentPagesEmpty.imageset/recent360.png D wikipedia/Images.xcassets/RecentPagesEmpty.imageset/svg and notes/notes.txt M wikipedia/Images.xcassets/SavedPagesEmpty.imageset/Contents.json A wikipedia/Images.xcassets/SavedPagesEmpty.imageset/savedpages.svg M wikipedia/Images.xcassets/SavedPagesEmpty.imageset/savedpages120.png M wikipedia/Images.xcassets/SavedPagesEmpty.imageset/savedpages240.png A wikipedia/Images.xcassets/SavedPagesEmpty.imageset/savedpages360.png D wikipedia/Images.xcassets/SavedPagesEmpty.imageset/svg and notes/notes.txt D wikipedia/Images.xcassets/SavedPagesEmpty.imageset/svg and notes/savedpages.svg M wikipedia/View Controllers/Onboarding/OnboardingViewController.m 29 files changed, 67 insertions(+), 66 deletions(-) Approvals: Brion VIBBER: Verified; Looks good to me, approved diff --git a/Wikipedia.xcodeproj/project.pbxproj b/Wikipedia.xcodeproj/project.pbxproj index fdbcd9e..dc41b63 100644 --- a/Wikipedia.xcodeproj/project.pbxproj +++ b/Wikipedia.xcodeproj/project.pbxproj @@ -1217,32 +1217,6 @@ isa = PBXGroup; children = ( 043F18DA18D9691D00D8489A /* TopActionSheet */, - 04B91AA518E34BBC00FFAA1C /* UIView+TemporaryAnimatedXF.h */, - 04B91AA618E34BBC00FFAA1C /* UIView+TemporaryAnimatedXF.m */, - 04DB0BE818BD37F900B4BCF3 /* UIScrollView+ScrollSubviewToLocation.h */, - 04DB0BE918BD37F900B4BCF3 /* UIScrollView+ScrollSubviewToLocation.m */, - 04C695D018ED213000D9F2DA /* UIScrollView+NoHorizontalScrolling.h */, - 04C695D118ED213000D9F2DA /* UIScrollView+NoHorizontalScrolling.m */, - 0415581A18ADFA5C00B81A59 /* UIImage+ColorMask.h */, - 0415581B18ADFA5C00B81A59 /* UIImage+ColorMask.m */, - 047801BC18AE987900DBB747 /* UIButton+ColorMask.h */, - 047801BD18AE987900DBB747 /* UIButton+ColorMask.m */, - 0433542418A093C5009305F0 /* UIView+RemoveConstraints.h */, - 0433542518A093C5009305F0 /* UIView+RemoveConstraints.m */, - 0400EB0118AAEEC60043ECE2 /* UINavigationController+SearchNavStack.h */, - 0400EB0218AAEEC60043ECE2 /* UINavigationController+SearchNavStack.m */, - 049B640A18AAF36200D98BD4 /* UIViewController+SearchChildViewControllers.h */, - 049B640B18AAF36200D98BD4 /* UIViewController+SearchChildViewControllers.m */, - 0433542018A023FE009305F0 /* UIViewController+HideKeyboard.h */, - 0433542118A023FE009305F0 /* UIViewController+HideKeyboard.m */, - 04090A39187FB7D000577EDF /* UIView+Debugging.h */, - 04090A3A187FB7D000577EDF /* UIView+Debugging.m */, - 04C695CC18ED08D900D9F2DA /* UIView+SearchSubviews.h */, - 04C695CD18ED08D900D9F2DA /* UIView+SearchSubviews.m */, - 04B6924E18E77B2A00F88D8A /* UIWebView+HideScrollGradient.h */, - 04B6924F18E77B2A00F88D8A /* UIWebView+HideScrollGradient.m */, - 04F0E2E8186EDC1A00468738 /* UIWebView+ElementLocation.h */, - 04F0E2E9186EDC1A00468738 /* UIWebView+ElementLocation.m */, 04D34DDF1868E21F00610A87 /* Article+Convenience.h */, 04D34DE01868E21F00610A87 /* Article+Convenience.m */, 047FF5451889078C009DB293 /* Image+Convenience.h */, @@ -1690,6 +1664,7 @@ 04272E75193FF7F000CC682F /* ShellScript */, D4C16A621970946900CD91AD /* ShellScript */, D4C16A631970949A00CD91AD /* ShellScript */, + 046F268119C387BD00D7ACB3 /* ShellScript */, D4991433181D51DE00E6073C /* Resources */, ); buildRules = ( @@ -1876,6 +1851,22 @@ shellPath = /bin/sh; shellScript = "scripts/run-grunt.sh"; }; + 046F268119C387BD00D7ACB3 /* ShellScript */ = { + isa = PBXShellScriptBuildPhase; + buildActionMask = 2147483647; + files = ( + ); + inputPaths = ( + "$(SRCROOT)/wikipedia/Images.xcassets/AppIcon.appiconset/icon.svg", + "$(SRCROOT)/wikipedia/Images.xcassets/RecentPagesEmpty.imageset/recent.svg", + "$(SRCROOT)/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/savedpages.svg", + ); + outputPaths = ( + ); + runOnlyForDeploymentPostprocessing = 0; + shellPath = /bin/sh; + shellScript = "scripts/icon-svgs-to-pngs.sh"; + }; D4C16A621970946900CD91AD /* ShellScript */ = { isa = PBXShellScriptBuildPhase; buildActionMask = 2147483647; diff --git a/scripts/icon-svgs-to-pngs.sh b/scripts/icon-svgs-to-pngs.sh new file mode 100755 index 0000000..2035179 --- /dev/null +++ b/scripts/icon-svgs-to-pngs.sh @@ -0,0 +1,7 @@ +#!/bin/sh + +ruby -e '[29,40,50,57,58,72,76,80,87,90,100,114,120,144,152,180].each { |x| `/Applications/Inkscape.app/Contents/Resources/bin/inkscape --export-png "wikipedia/Images.xcassets/AppIcon.appiconset/icon#{x}.png" -w #{x} '"$SCRIPT_INPUT_FILE_0"'` }' + +ruby -e '[120,240,360].each { |x| `/Applications/Inkscape.app/Contents/Resources/bin/inkscape --export-png "wikipedia/Images.xcassets/RecentPagesEmpty.imageset/recent#{x}.png" -w #{x} '"$SCRIPT_INPUT_FILE_1"'` }' + +ruby -e '[120,240,360].each { |x| `/Applications/Inkscape.app/Contents/Resources/bin/inkscape --export-png "wikipedia/Images.xcassets/SavedPagesEmpty.imageset/savedpages#{x}.png" -w #{x} '"$SCRIPT_INPUT_FILE_2"'` }' diff --git a/wikipedia/AppDelegate.m b/wikipedia/AppDelegate.m index f137d7e..75c99b6 100644 --- a/wikipedia/AppDelegate.m +++ b/wikipedia/AppDelegate.m @@ -31,6 +31,11 @@ //[self printAllNotificationsToConsole]; +#if TARGET_IPHONE_SIMULATOR + // From: http://pinkstone.co.uk/where-is-the-documents-directory-for-the-ios-8-simulator/ + NSLog(@"\n\n\nSimulator Documents Directory:\n%@\n\n\n", [[[NSFileManager defaultManager] URLsForDirectory:NSDocumentDirectory inDomains:NSUserDomainMask] lastObject]); +#endif + return YES; } diff --git a/wikipedia/Fonts/makeFontFromSvgs.py b/wikipedia/Fonts/makeFontFromSvgs.py index 0b249a8..7dca50a 100755 --- a/wikipedia/Fonts/makeFontFromSvgs.py +++ b/wikipedia/Fonts/makeFontFromSvgs.py @@ -1,5 +1,8 @@ #!/usr/local/bin/fontforge +# Created by Monte Hurd on 9/1/14. +# Copyright (c) 2014 Wikimedia Foundation. Provided under MIT-style license; please copy and modify! +# # Makes "./font.ttf" from svg files found in "./svgs/". # Svg's must be named according to following convention: # "UNICODE_CHAR GLYPH_NAME LEFT_BEARING RIGHT_BEARING BASELINE_OFFSET.svg" diff --git a/wikipedia/Fonts/makeSvgsFromFont.py b/wikipedia/Fonts/makeSvgsFromFont.py index 582c0b2..2f43a5e 100755 --- a/wikipedia/Fonts/makeSvgsFromFont.py +++ b/wikipedia/Fonts/makeSvgsFromFont.py @@ -1,5 +1,8 @@ #!/usr/local/bin/fontforge +# Created by Monte Hurd on 9/1/14. +# Copyright (c) 2014 Wikimedia Foundation. Provided under MIT-style license; please copy and modify! +# # Extracts svg for each glyph in "./font.ttf" to "./svgs/" folder. # Also extracts font settings to "./font.json" file. diff --git a/wikipedia/Images.xcassets/AppIcon.appiconset/Contents.json b/wikipedia/Images.xcassets/AppIcon.appiconset/Contents.json index 99c2814..ce7c064 100644 --- a/wikipedia/Images.xcassets/AppIcon.appiconset/Contents.json +++ b/wikipedia/Images.xcassets/AppIcon.appiconset/Contents.json @@ -13,10 +13,22 @@ "scale" : "2x" }, { + "size" : "29x29", + "idiom" : "iphone", + "filename" : "icon87-1.png", + "scale" : "3x" + }, + { "size" : "40x40", "idiom" : "iphone", "filename" : "icon80.png", "scale" : "2x" + }, + { + "size" : "40x40", + "idiom" : "iphone", + "filename" : "icon120-1.png", + "scale" : "3x" }, { "size" : "57x57", @@ -37,8 +49,9 @@ "scale" : "2x" }, { - "idiom" : "iphone", "size" : "60x60", + "idiom" : "iphone", + "filename" : "icon180-1.png", "scale" : "3x" }, { diff --git a/wikipedia/Images.xcassets/AppIcon.appiconset/svg and notes/icon.svg b/wikipedia/Images.xcassets/AppIcon.appiconset/icon.svg similarity index 100% rename from wikipedia/Images.xcassets/AppIcon.appiconset/svg and notes/icon.svg rename to wikipedia/Images.xcassets/AppIcon.appiconset/icon.svg diff --git a/wikipedia/Images.xcassets/AppIcon.appiconset/icon120-1.png b/wikipedia/Images.xcassets/AppIcon.appiconset/icon120-1.png new file mode 100644 index 0000000..3949451 --- /dev/null +++ b/wikipedia/Images.xcassets/AppIcon.appiconset/icon120-1.png Binary files differ diff --git a/wikipedia/Images.xcassets/AppIcon.appiconset/icon180-1.png b/wikipedia/Images.xcassets/AppIcon.appiconset/icon180-1.png new file mode 100644 index 0000000..5af352f --- /dev/null +++ b/wikipedia/Images.xcassets/AppIcon.appiconset/icon180-1.png Binary files differ diff --git a/wikipedia/Images.xcassets/AppIcon.appiconset/icon180.png b/wikipedia/Images.xcassets/AppIcon.appiconset/icon180.png new file mode 100644 index 0000000..907203d --- /dev/null +++ b/wikipedia/Images.xcassets/AppIcon.appiconset/icon180.png Binary files differ diff --git a/wikipedia/Images.xcassets/AppIcon.appiconset/icon87-1.png b/wikipedia/Images.xcassets/AppIcon.appiconset/icon87-1.png new file mode 100644 index 0000000..4ac3efb --- /dev/null +++ b/wikipedia/Images.xcassets/AppIcon.appiconset/icon87-1.png Binary files differ diff --git a/wikipedia/Images.xcassets/AppIcon.appiconset/icon87.png b/wikipedia/Images.xcassets/AppIcon.appiconset/icon87.png new file mode 100644 index 0000000..42a94b5 --- /dev/null +++ b/wikipedia/Images.xcassets/AppIcon.appiconset/icon87.png Binary files differ diff --git a/wikipedia/Images.xcassets/AppIcon.appiconset/icon90.png b/wikipedia/Images.xcassets/AppIcon.appiconset/icon90.png new file mode 100644 index 0000000..5aab3f4 --- /dev/null +++ b/wikipedia/Images.xcassets/AppIcon.appiconset/icon90.png Binary files differ diff --git a/wikipedia/Images.xcassets/AppIcon.appiconset/svg and notes/notes.txt b/wikipedia/Images.xcassets/AppIcon.appiconset/svg and notes/notes.txt deleted file mode 100644 index 46d7484..0000000 --- a/wikipedia/Images.xcassets/AppIcon.appiconset/svg and notes/notes.txt +++ /dev/null @@ -1,7 +0,0 @@ -from: - - http://throwachair.com/2013/10/26/generate-all-your-ios-app-icons-with-svg-and-inkscape/ - -cd to this dir then run: - - ruby -e '[29,40,50,57,58,72,76,80,100,114,120,144,152].each { |x| `/Applications/Inkscape.app/Contents/Resources/bin/inkscape --export-png icon#{x}.png -w #{x} icon.svg` }' \ No newline at end of file diff --git a/wikipedia/Images.xcassets/LaunchImage.launchimage/splash_1242x2208-1.png b/wikipedia/Images.xcassets/LaunchImage.launchimage/splash_1242x2208-1.png index 833f74c..1d2e701 100644 --- a/wikipedia/Images.xcassets/LaunchImage.launchimage/splash_1242x2208-1.png +++ b/wikipedia/Images.xcassets/LaunchImage.launchimage/splash_1242x2208-1.png Binary files differ diff --git a/wikipedia/Images.xcassets/LaunchImage.launchimage/splash_2208x1242-1.png b/wikipedia/Images.xcassets/LaunchImage.launchimage/splash_2208x1242-1.png index 14bcbe8..8953e9b 100644 --- a/wikipedia/Images.xcassets/LaunchImage.launchimage/splash_2208x1242-1.png +++ b/wikipedia/Images.xcassets/LaunchImage.launchimage/splash_2208x1242-1.png Binary files differ diff --git a/wikipedia/Images.xcassets/LaunchImage.launchimage/splash_750x1334-1.png b/wikipedia/Images.xcassets/LaunchImage.launchimage/splash_750x1334-1.png index b1cc040..6dc8b31 100644 --- a/wikipedia/Images.xcassets/LaunchImage.launchimage/splash_750x1334-1.png +++ b/wikipedia/Images.xcassets/LaunchImage.launchimage/splash_750x1334-1.png Binary files differ diff --git a/wikipedia/Images.xcassets/RecentPagesEmpty.imageset/Contents.json b/wikipedia/Images.xcassets/RecentPagesEmpty.imageset/Contents.json index 3fa1785..9f8eadd 100644 --- a/wikipedia/Images.xcassets/RecentPagesEmpty.imageset/Contents.json +++ b/wikipedia/Images.xcassets/RecentPagesEmpty.imageset/Contents.json @@ -12,7 +12,8 @@ }, { "idiom" : "universal", - "scale" : "3x" + "scale" : "3x", + "filename" : "recent360.png" } ], "info" : { diff --git a/wikipedia/Images.xcassets/RecentPagesEmpty.imageset/svg and notes/recent.svg b/wikipedia/Images.xcassets/RecentPagesEmpty.imageset/recent.svg similarity index 100% rename from wikipedia/Images.xcassets/RecentPagesEmpty.imageset/svg and notes/recent.svg rename to wikipedia/Images.xcassets/RecentPagesEmpty.imageset/recent.svg diff --git a/wikipedia/Images.xcassets/RecentPagesEmpty.imageset/recent360.png b/wikipedia/Images.xcassets/RecentPagesEmpty.imageset/recent360.png new file mode 100644 index 0000000..f0dc60e --- /dev/null +++ b/wikipedia/Images.xcassets/RecentPagesEmpty.imageset/recent360.png Binary files differ diff --git a/wikipedia/Images.xcassets/RecentPagesEmpty.imageset/svg and notes/notes.txt b/wikipedia/Images.xcassets/RecentPagesEmpty.imageset/svg and notes/notes.txt deleted file mode 100644 index 80cc94f..0000000 --- a/wikipedia/Images.xcassets/RecentPagesEmpty.imageset/svg and notes/notes.txt +++ /dev/null @@ -1,7 +0,0 @@ -from: - - http://throwachair.com/2013/10/26/generate-all-your-ios-app-icons-with-svg-and-inkscape/ - -cd to this dir then run: - - ruby -e '[120,240].each { |x| `/Applications/Inkscape.app/Contents/Resources/bin/inkscape --export-png ../recent#{x}.png -w #{x} recent.svg` }' \ No newline at end of file diff --git a/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/Contents.json b/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/Contents.json index 7c8fbed..b5589f7 100644 --- a/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/Contents.json +++ b/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/Contents.json @@ -12,7 +12,8 @@ }, { "idiom" : "universal", - "scale" : "3x" + "scale" : "3x", + "filename" : "savedpages360.png" } ], "info" : { diff --git a/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/savedpages.svg b/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/savedpages.svg new file mode 100644 index 0000000..1cb3946 --- /dev/null +++ b/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/savedpages.svg @@ -0,0 +1,13 @@ +<?xml version="1.0" encoding="utf-8"?> +<!-- Generator: Adobe Illustrator 18.0.0, SVG Export Plug-In . SVG Version: 6.00 Build 0) --> +<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd"> +<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px" + viewBox="0 0 240 232" enable-background="new 0 0 240 232" xml:space="preserve"> +<circle fill="#010101" cx="90" cy="94.6" r="9"/> +<circle fill="#010101" cx="148" cy="94.6" r="9"/> +<path fill="none" stroke="#010101" stroke-width="7" stroke-linecap="round" stroke-miterlimit="10" d="M92,137.1 + c14.9-14.9,39.1-14.9,54,0"/> +<path fill="none" stroke="#010101" stroke-width="9" stroke-miterlimit="10" d="M188.8,37.8C164,26.3,131.5,37.1,120,61.9 + c-11.5-24.8-44-35.6-68.8-24.1C24.7,50,12,81.4,32.9,118.4c14.8,26.3,41.2,46.2,87.1,81.7c45.9-35.6,72.2-55.4,87.1-81.7 + C228,81.4,215.3,50,188.8,37.8z"/> +</svg> diff --git a/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/savedpages120.png b/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/savedpages120.png index 20a6868..bdcee97 100644 --- a/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/savedpages120.png +++ b/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/savedpages120.png Binary files differ diff --git a/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/savedpages240.png b/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/savedpages240.png index 04ddffc..0e24195 100644 --- a/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/savedpages240.png +++ b/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/savedpages240.png Binary files differ diff --git a/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/savedpages360.png b/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/savedpages360.png new file mode 100644 index 0000000..4045d00 --- /dev/null +++ b/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/savedpages360.png Binary files differ diff --git a/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/svg and notes/notes.txt b/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/svg and notes/notes.txt deleted file mode 100644 index d5d7666..0000000 --- a/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/svg and notes/notes.txt +++ /dev/null @@ -1,7 +0,0 @@ -from: - - http://throwachair.com/2013/10/26/generate-all-your-ios-app-icons-with-svg-and-inkscape/ - -cd to this dir then run: - - ruby -e '[120,240].each { |x| `/Applications/Inkscape.app/Contents/Resources/bin/inkscape --export-png ../savedpages#{x}.png -w #{x} savedpages.svg` }' \ No newline at end of file diff --git a/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/svg and notes/savedpages.svg b/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/svg and notes/savedpages.svg deleted file mode 100644 index 02c8c8c..0000000 --- a/wikipedia/Images.xcassets/SavedPagesEmpty.imageset/svg and notes/savedpages.svg +++ /dev/null @@ -1,16 +0,0 @@ -<?xml version="1.0" encoding="utf-8"?> -<!-- Generator: Adobe Illustrator 18.0.0, SVG Export Plug-In . SVG Version: 6.00 Build 0) --> -<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd"> -<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px" - viewBox="0 0 255.8 246.8" enable-background="new 0 0 255.8 246.8" xml:space="preserve"> -<g> - <path fill="none" stroke="#000000" stroke-width="8" stroke-miterlimit="10" d="M134.1,26.9l27.1,54.9c1,2.1,3,3.5,5.2,3.8 - l60.6,8.8c5.7,0.8,8,7.8,3.9,11.9l-43.9,42.8c-1.6,1.6-2.4,3.9-2,6.2l10.4,60.4c1,5.7-5,10-10.1,7.3l-54.2-28.5 - c-2-1.1-4.5-1.1-6.5,0L70.4,223c-5.1,2.7-11.1-1.7-10.1-7.3l10.4-60.4c0.4-2.3-0.4-4.6-2-6.2l-43.9-42.8c-4.1-4-1.9-11,3.9-11.9 - l60.6-8.8c2.3-0.3,4.2-1.8,5.2-3.8l27.1-54.9C124.2,21.7,131.6,21.7,134.1,26.9z"/> - <circle cx="104.4" cy="113.8" r="9"/> - <circle cx="158.4" cy="113.8" r="9"/> - <path fill="none" stroke="#000000" stroke-width="5" stroke-linecap="round" stroke-miterlimit="10" d="M98.2,153.3 - c18.4-18.4,48.1-18.4,66.5,0"/> -</g> -</svg> diff --git a/wikipedia/View Controllers/Onboarding/OnboardingViewController.m b/wikipedia/View Controllers/Onboarding/OnboardingViewController.m index 94904b2..3c25b10 100644 --- a/wikipedia/View Controllers/Onboarding/OnboardingViewController.m +++ b/wikipedia/View Controllers/Onboarding/OnboardingViewController.m @@ -53,6 +53,7 @@ - (NSUInteger)supportedInterfaceOrientations { + //return UIInterfaceOrientationMaskAll; return (UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPhone) ? UIInterfaceOrientationMaskPortrait : UIInterfaceOrientationMaskAll; } -- To view, visit https://gerrit.wikimedia.org/r/160116 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5845776be390f61351e06117c0887f1a9532d1f Gerrit-PatchSet: 2 Gerrit-Project: apps/ios/wikipedia Gerrit-Branch: master Gerrit-Owner: Mhurd <mh...@wikimedia.org> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits