jenkins-bot has submitted this change and it was merged.
Change subject: ve.ui.AnnotationInspector: Apply existing annotations to
inserted content
......................................................................
ve.ui.AnnotationInspector: Apply existing annotations to inserted content
Turns out this is already implemented, just not used. Blaming related
lines provided me with no insight why it was done this way, and I
don't see anything that this change would break.
Bug: 70534
Change-Id: Ibd77057405f5080e70265abc3043abcd07da9511
---
M src/ui/inspectors/ve.ui.AnnotationInspector.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ui/inspectors/ve.ui.AnnotationInspector.js
b/src/ui/inspectors/ve.ui.AnnotationInspector.js
index b863d76..53f2cac 100644
--- a/src/ui/inspectors/ve.ui.AnnotationInspector.js
+++ b/src/ui/inspectors/ve.ui.AnnotationInspector.js
@@ -255,7 +255,7 @@
if ( insertText ) {
insertion = this.getInsertionData();
if ( insertion.length ) {
- fragment.insertContent( insertion,
false );
+ fragment.insertContent( insertion, true
);
// Move cursor to the end of the
inserted content, even if back button is used
fragment.adjustRange(
-insertion.length, 0 );
this.previousSelection = new ve.Range(
--
To view, visit https://gerrit.wikimedia.org/r/160216
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd77057405f5080e70265abc3043abcd07da9511
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
