Chmarkine has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/160528

Change subject: racktables - remove RewriteCond on /status
......................................................................

racktables - remove RewriteCond on /status

As I mentioned in Idc9a448f comment 14, all HTTP connection to
racktable redirects to HTTPS except for:
http://racktables.wikimedia.org/status

But I don't see a reason why this URL should be excluded; especially
it actually returns 404. So this patch removes the line:
RewriteCond %{REQUEST_URI} !^/status$

Change-Id: I610d984b81e6a7e188398db27b92bd6eff2a07ee
---
M templates/apache/sites/racktables.wikimedia.org.erb
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/28/160528/1

diff --git a/templates/apache/sites/racktables.wikimedia.org.erb 
b/templates/apache/sites/racktables.wikimedia.org.erb
index 757bf6b..f414df1 100644
--- a/templates/apache/sites/racktables.wikimedia.org.erb
+++ b/templates/apache/sites/racktables.wikimedia.org.erb
@@ -10,7 +10,6 @@
 
     RewriteEngine on
     RewriteCond %{HTTP:X-Forwarded-Proto} !https
-    RewriteCond %{REQUEST_URI} !^/status$
     RewriteRule ^/(.*)$ https://%{HTTP_HOST}%{REQUEST_URI} 
[R=301,E=ProtoRedirect]
     Header always merge Vary X-Forwarded-Proto env=ProtoRedirect
 

-- 
To view, visit https://gerrit.wikimedia.org/r/160528
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I610d984b81e6a7e188398db27b92bd6eff2a07ee
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Chmarkine <chmark...@hotmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to