[MediaWiki-commits] [Gerrit] Remove usage of spinner.gif - change (mediawiki...SecurePoll)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Remove usage of spinner.gif
......................................................................


Remove usage of spinner.gif

Use .mw-small-spinner class instead, which isn't exactly a recommended
interface, but it's not deprecated either and it's easy to replace
here.

Bug: 70615
Change-Id: I753ec1f1e5464a751c7c20481ae49a07cba1d7c4
---
M includes/pages/ListPage.php
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  CSteipp: Looks good to me, but someone else must approve
  Aaron Schulz: Looks good to me, approved
  Jforrester: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/includes/pages/ListPage.php b/includes/pages/ListPage.php
index 13df424..7e8eeeb 100644
--- a/includes/pages/ListPage.php
+++ b/includes/pages/ListPage.php
@@ -12,7 +12,7 @@
         * @param $params array Array of subpage parameters.
         */
        function execute( $params ) {
-               global $wgOut, $wgUser, $wgStylePath;
+               global $wgOut, $wgUser;
 
                if ( !count( $params ) ) {
                        $wgOut->addWikiMsg( 'securepoll-too-few-params' );
@@ -43,7 +43,6 @@
                        $msgCancel = wfMsgHtml( 'securepoll-strike-cancel' );
                        $msgReason = wfMsgHtml( 'securepoll-strike-reason' );
                        $encAction = htmlspecialchars( 
$this->getTitle()->getLocalUrl() );
-                       $encSpinner = htmlspecialchars( 
"$wgStylePath/common/images/spinner.gif" );
                        $script = Skin::makeVariablesScript( array(
                                'securepoll_strike_button' => wfMsg( 
'securepoll-strike-button' ),
                                'securepoll_unstrike_button' => wfMsg( 
'securepoll-unstrike-button' )
@@ -67,7 +66,7 @@
 </p>
 </form>
 <div id="securepoll-strike-result"></div>
-<div id="securepoll-strike-spinner"><img src="$encSpinner"/></div>
+<div id="securepoll-strike-spinner" class="mw-small-spinner"></div>
 </div>
 EOT
                        );

-- 
To view, visit https://gerrit.wikimedia.org/r/159370
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I753ec1f1e5464a751c7c20481ae49a07cba1d7c4
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/SecurePoll
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Anomie <bjor...@wikimedia.org>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: CSteipp <cste...@wikimedia.org>
Gerrit-Reviewer: Hashar <has...@free.fr>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits