Mattflaschen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/161475
Change subject: DO NOT MERGE: Audit notes for GettingStarted
......................................................................
DO NOT MERGE: Audit notes for GettingStarted
Change-Id: Ied91793e22424b045a6e29a49530957d4fc78157
---
M GettingStarted.php
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GettingStarted
refs/changes/75/161475/1
diff --git a/GettingStarted.php b/GettingStarted.php
index 16ba0e3..c6b1cd1 100644
--- a/GettingStarted.php
+++ b/GettingStarted.php
@@ -12,6 +12,7 @@
'Ori Livneh',
'S Page',
'Sam Smith',
+ 'Rob Moen',
),
'url' => 'https://www.mediawiki.org/wiki/Extension:GettingStarted',
'descriptionmsg' => 'gettingstarted-desc',
@@ -30,6 +31,7 @@
'toolbarDescription' =>
'gettingstarted-task-copyedit-toolbar-description',
'toolbarTryAnotherTitle' =>
'gettingstarted-task-copyedit-toolbar-try-another-title',
),
+ /*
'clarify' => array(
'toolbarDescription' =>
'gettingstarted-task-clarify-toolbar-description',
'toolbarTryAnotherTitle' =>
'gettingstarted-task-clarify-toolbar-try-another-title',
@@ -38,6 +40,7 @@
'toolbarDescription' =>
'gettingstarted-task-addlinks-toolbar-description',
'toolbarTryAnotherTitle' =>
'gettingstarted-task-addlinks-toolbar-try-another-title',
)
+ */
);
/**
@@ -67,6 +70,7 @@
'serializer' => 'none',
);
+// Possibly remove pending Thu.
/**
* Is the controlled experiment enabled?
*/
@@ -99,6 +103,7 @@
);
$wgMessagesDirs['GettingStarted'] = __DIR__ . '/i18n';
+// Remove
$wgExtensionMessagesFiles[ 'GettingStarted' ] = __DIR__ .
'/GettingStarted.i18n.php';
// APIs
@@ -112,6 +117,7 @@
'remoteExtPath' => 'GettingStarted/resources',
);
+// Remove
$wgResourceModules[ 'schema.GettingStartedNavbarNoArticle' ] = array(
'class' => 'ResourceLoaderSchemaModule',
'schema' => 'GettingStartedNavbarNoArticle',
@@ -173,6 +179,7 @@
),
) + $gettingStartedModuleInfo;
+// Eval lightbulb ones Thu.
$wgResourceModules[ 'ext.gettingstarted.lightbulb.postEdit' ] = array(
'scripts' => array(
'lightbulb/lightbulb.postEdit.js',
@@ -242,6 +249,7 @@
),
) + $gettingStartedModuleInfo;
+// Keep, but check for dead code
$wgResourceModules[ 'ext.gettingstarted.logging' ] = array(
'scripts' => 'ext.gettingstarted.logging.js',
'dependencies' => array(
@@ -301,6 +309,9 @@
// This runs on account creation for the OB6 test behavior (returnTo page with
// special behavior), possibly displaying a Call To Action.
+
+// Try to integrate with other code, e.g. showing a button that launches a tour
+// of the flyout.
$wgResourceModules[ 'ext.gettingstarted.return' ] = array(
'scripts' => 'ext.gettingstarted.return.js',
'styles' => 'ext.gettingstarted.return.less',
@@ -330,6 +341,8 @@
'position' => 'top',
) + $gettingStartedModuleInfo;
+// Remove in separate step (with assignToken), since only
+// used for anon acquisition.
$wgResourceModules[ 'ext.gettingstarted.user' ] = array(
'scripts' => array(
'ext.gettingstarted.bucket.js',
@@ -372,6 +385,7 @@
),
) + $anonymousEditorAcquisitionPreEditTourInfo;
+// Remove
$wgResourceModules[ 'ext.gettingstarted.anonymousEditorAcquisition' ] = array(
'scripts' => 'ext.gettingstarted.anonymousEditorAcquisition.js',
'dependencies' => array(
@@ -434,6 +448,7 @@
'revision' => 9266317
);
+// Remove with user
$wgResourceModules[ 'ext.gettingstarted.assignToken' ] = array(
'scripts' => 'ext.gettingstarted.assignToken.js',
'dependencies' => array(
@@ -441,6 +456,7 @@
),
) + $gettingStartedModuleInfo;
+// Whether to show introductory tour about toolbar
$wgDefaultUserOptions[ GettingStarted\Hooks::INTRO_OPTION ] = true;
$wgHooks[ 'BeforePageDisplay' ][] =
'GettingStarted\Hooks::onBeforePageDisplay';
--
To view, visit https://gerrit.wikimedia.org/r/161475
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied91793e22424b045a6e29a49530957d4fc78157
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
