Jeroen De Dauw has submitted this change and it was merged.
Change subject: Remove removeReferences from AbstractedRepoApi
......................................................................
Remove removeReferences from AbstractedRepoApi
Change-Id: Ic82ae1ea311205a32167d2ab76b5d48370e3f62d
---
M lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
M lib/resources/wikibase.RepoApi/wikibase.AbstractedRepoApi.js
2 files changed, 4 insertions(+), 22 deletions(-)
Approvals:
Jeroen De Dauw: Looks good to me, approved
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
index 0958357..a5919d0 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
@@ -348,15 +348,16 @@
* @return {jQuery.Promise}
*/
_removeReferenceApiCall: function( reference ) {
- var abstractedApi = this.option( 'api' ),
+ var repoApi = this.option( 'api' ),
guid = this.value().getGuid();
- return abstractedApi.removeReferences(
+ return repoApi.removeReferences(
guid,
reference.getHash(),
wb.getRevisionStore().getClaimRevision( guid ),
this.option( 'index' )
- ).done( function( baseRevId ) {
+ ).done( function( result ) {
+ var baseRevId = result.pageinfo;
// update revision store
wb.getRevisionStore().setClaimRevision( baseRevId, guid
);
} );
diff --git a/lib/resources/wikibase.RepoApi/wikibase.AbstractedRepoApi.js
b/lib/resources/wikibase.RepoApi/wikibase.AbstractedRepoApi.js
index f74ce72..4efbbc0 100644
--- a/lib/resources/wikibase.RepoApi/wikibase.AbstractedRepoApi.js
+++ b/lib/resources/wikibase.RepoApi/wikibase.AbstractedRepoApi.js
@@ -38,25 +38,6 @@
},
/**
- * Will remove one or more existing References of a Statement.
- *
- * @since 0.4
- *
- * @param {string} statementGuid
- * @param {string|string[]} referenceHashes One or more hashes of the
References to be removed.
- * @param {number} baseRevId
- * @return {jQuery.Promise} Done callbacks will receive new base
revision ID as first parameter.
- */
- removeReferences: function( statementGuid, referenceHashes, baseRevId )
{
- return this._abstract(
- PARENT.prototype.removeReferences.apply( this,
arguments ),
- function( result ) {
- return [ result.pageinfo ];
- }
- );
- },
-
- /**
* Adds a new or updates an existing Reference of a Statement.
*
* @since 0.4
--
To view, visit https://gerrit.wikimedia.org/r/160649
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic82ae1ea311205a32167d2ab76b5d48370e3f62d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <adrian.l...@wikimedia.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
