[MediaWiki-commits] [Gerrit] Improve type hints in ValuesFinder - change (mediawiki...Wikibase)

[Jeroen De Dauw (Code Review)]

Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/161681

Change subject: Improve type hints in ValuesFinder
......................................................................

Improve type hints in ValuesFinder

Change-Id: Ia4c7f881d615f7ba9e0254b320f06312cd481811
---
M lib/includes/ValuesFinder.php
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/81/161681/1

diff --git a/lib/includes/ValuesFinder.php b/lib/includes/ValuesFinder.php
index cb46f68..7f017bc 100644
--- a/lib/includes/ValuesFinder.php
+++ b/lib/includes/ValuesFinder.php
@@ -2,6 +2,8 @@
 
 namespace Wikibase;
 
+use DataValues\DataValue;
+use Wikibase\DataModel\Snak\PropertyValueSnak;
 use Wikibase\Lib\PropertyDataTypeLookup;
 use Wikibase\Lib\PropertyNotFoundException;
 
@@ -37,6 +39,9 @@
 
                foreach ( $snaks as $snak ) {
                        if ( $this->isMatchingSnak( $snak, $dataType ) ) {
+                               /**
+                                * @var PropertyValueSnak $snak
+                                */
                                $dataValue = $snak->getDataValue();
                                $found[$dataValue->getHash()] = $dataValue;
                        }

-- 
To view, visit https://gerrit.wikimedia.org/r/161681
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4c7f881d615f7ba9e0254b320f06312cd481811
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits