[MediaWiki-commits] [Gerrit] Simplify loading CSS - change (mediawiki...GettingStarted)

[Phuedx (Code Review)]

Phuedx has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/161941

Change subject: Simplify loading CSS
......................................................................

Simplify loading CSS

Change-Id: Ia30e7ed55b41abcedb6a1e82a3eaa08bb952414a
---
M resources/lightbulb/lightbulb.flyout.js
M resources/lightbulb/lightbulb.flyout.less
2 files changed, 5 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GettingStarted 
refs/changes/41/161941/1

diff --git a/resources/lightbulb/lightbulb.flyout.js 
b/resources/lightbulb/lightbulb.flyout.js
index 413e539..989acb8 100644
--- a/resources/lightbulb/lightbulb.flyout.js
+++ b/resources/lightbulb/lightbulb.flyout.js
@@ -27,7 +27,6 @@
                                        </a>\
                                </div>\
                                <div 
class="mw-gettingstarted-lightbulb-flyout-loader">\
-                                       <div 
class="mw-gettingstarted-lightbulb-flyout-loader-spinner"></div>\
                                </div>\
                                <div class="guider_arrow guider_arrow_up 
guider_arrow_center">\
                                        <div 
class="guider_arrow_inner_container">\
diff --git a/resources/lightbulb/lightbulb.flyout.less 
b/resources/lightbulb/lightbulb.flyout.less
index 700b5d6..42f483f 100644
--- a/resources/lightbulb/lightbulb.flyout.less
+++ b/resources/lightbulb/lightbulb.flyout.less
@@ -204,18 +204,12 @@
 
 .mw-gettingstarted-lightbulb-flyout-loader {
        margin: auto;
-       padding: 45px 71px;
        display: none;
-
-       .mw-gettingstarted-lightbulb-flyout-loader-spinner {
-               margin: auto;
-               width: 32px;
-               height: 32px;
-               background-position: center;
-               background-size: 32px;
-               // Graceful degradation for browsers that don't support 
background-size
-               .background-image-svg('images/ajax-loader-2x.gif', 
'images/ajax-loader.gif');
-       }
+       height: 122px;
+       background-position: center;
+       background-size: 32px;
+       background-repeat: no-repeat;
+       .background-image-svg('images/ajax-loader-2x.gif', 
'images/ajax-loader.gif');
 }
 
 // TODO (phuedx, 2014/07/30): Classes like this would simplify the

-- 
To view, visit https://gerrit.wikimedia.org/r/161941
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia30e7ed55b41abcedb6a1e82a3eaa08bb952414a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: master
Gerrit-Owner: Phuedx <g...@samsmith.io>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits