Cmcmahon has uploaded a new change for review.
https://gerrit.wikimedia.org/r/161953
Change subject: QA: straightforward id for new beta label element
......................................................................
QA: straightforward id for new beta label element
Also, no test uses the "I am in alpha mode" step any more
Change-Id: Ic07988655eabf76ce59ef43b4b0ac382bfa8e11e
---
M tests/browser/features/step_definitions/common_steps.rb
M tests/browser/features/support/pages/mobile_options_page.rb
2 files changed, 1 insertion(+), 20 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/53/161953/1
diff --git a/tests/browser/features/step_definitions/common_steps.rb
b/tests/browser/features/step_definitions/common_steps.rb
index 4236d8e..7111bd0 100644
--- a/tests/browser/features/step_definitions/common_steps.rb
+++ b/tests/browser/features/step_definitions/common_steps.rb
@@ -54,17 +54,6 @@
end
end
-Given /^I am in alpha mode$/ do
- visit(MobileOptions) do |page|
- page.beta_element.when_present.click
- page.save_settings_element.when_present.click
- visit(MobileOptions) do |page|
- page.alpha_element.when_present.click
- page.save_settings_element.when_present.click
- end
- end
-end
-
Given(/^I am on the "(.+)" page$/) do |article|
# Ensure we do not cause a redirect
article = article.sub(/ /, '_')
diff --git a/tests/browser/features/support/pages/mobile_options_page.rb
b/tests/browser/features/support/pages/mobile_options_page.rb
index 0cca8dd..3696e5d 100644
--- a/tests/browser/features/support/pages/mobile_options_page.rb
+++ b/tests/browser/features/support/pages/mobile_options_page.rb
@@ -4,14 +4,6 @@
include URL
page_url URL.url("Special:MobileOptions")
- div(:beta_parent, id: "enable-beta-toggle")
- div(:alpha_parent, id: "enable-alpha-toggle")
-
- span(:beta) do |page|
- page.beta_parent_element.span_element(class: "mw-mf-settings-off")
- end
- span(:alpha) do |page|
- page.alpha_parent_element.span_element(class: "mw-mf-settings-off")
- end
+ label(:beta, css: "div.mobileoption:nth-child(3) > div:nth-child(1) >
label:nth-child(2)")
button(:save_settings, id:"mw-mf-settings-save")
end
--
To view, visit https://gerrit.wikimedia.org/r/161953
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic07988655eabf76ce59ef43b4b0ac382bfa8e11e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <cmcma...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
