Kaldari has uploaded a new change for review.
https://gerrit.wikimedia.org/r/162789
Change subject: Removing if statements that will never be true
......................................................................
Removing if statements that will never be true
We already check for $units earlier and return if it exists.
Change-Id: I5b269bfc2ed01e45edbf51fba28f6b413bd7ea68
---
M TimeUnits.body.php
1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/cldr
refs/changes/89/162789/1
diff --git a/TimeUnits.body.php b/TimeUnits.body.php
index 1cbe531..417250c 100644
--- a/TimeUnits.body.php
+++ b/TimeUnits.body.php
@@ -33,9 +33,6 @@
// MediaWiki 1.19
$fallbacks = Language::getFallbacksFor( $code );
foreach ( $fallbacks as $fallback ) {
- if ( $units ) {
- break;
- }
// Get time units from a fallback language
$units = self::loadLanguage( $fallback );
}
@@ -43,9 +40,6 @@
// MediaWiki 1.18 or earlier
$fallback = $code;
while ( $fallback = Language::getFallbackFor( $fallback
) ) {
- if ( $units ) {
- break;
- }
// Get time units from a fallback language
$units = self::loadLanguage( $fallback );
}
--
To view, visit https://gerrit.wikimedia.org/r/162789
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b269bfc2ed01e45edbf51fba28f6b413bd7ea68
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/cldr
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
