[MediaWiki-commits] [Gerrit] Drop a few additional EntityId type annotations that are bre... - change (mediawiki...Wikidata)

[Ori.livneh (Code Review)]

Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/163037

Change subject: Drop a few additional EntityId type annotations that are 
breaking in prod
......................................................................

Drop a few additional EntityId type annotations that are breaking in prod

Change-Id: I0acd2096d21bbcff18014fa006428932ce087aff
---
M extensions/Wikibase/client/includes/recentchanges/ExternalChange.php
M extensions/Wikibase/repo/includes/ClaimDifferenceVisualizer.php
M extensions/Wikibase/repo/includes/EntityViewPlaceholderExpander.php
M extensions/Wikibase/repo/includes/store/EntityPerPage.php
M extensions/Wikibase/repo/includes/store/sql/EntityPerPageTable.php
5 files changed, 7 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikidata 
refs/changes/37/163037/1

diff --git 
a/extensions/Wikibase/client/includes/recentchanges/ExternalChange.php 
b/extensions/Wikibase/client/includes/recentchanges/ExternalChange.php
index df0f227..3e23f04 100644
--- a/extensions/Wikibase/client/includes/recentchanges/ExternalChange.php
+++ b/extensions/Wikibase/client/includes/recentchanges/ExternalChange.php
@@ -32,7 +32,7 @@
         * @param RevisionData $rev
         * @param string $changeType
         */
-       public function __construct( EntityId $entityId, RevisionData $rev, 
$changeType ) {
+       public function __construct( $entityId, RevisionData $rev, $changeType 
) {
                $this->entityId = $entityId;
                $this->rev = $rev;
                $this->changeType = $changeType;
diff --git a/extensions/Wikibase/repo/includes/ClaimDifferenceVisualizer.php 
b/extensions/Wikibase/repo/includes/ClaimDifferenceVisualizer.php
index 47d01f1..4d51a31 100644
--- a/extensions/Wikibase/repo/includes/ClaimDifferenceVisualizer.php
+++ b/extensions/Wikibase/repo/includes/ClaimDifferenceVisualizer.php
@@ -267,7 +267,7 @@
         *
         * @return string HTML
         */
-       protected function formatPropertyId( EntityId $entityId ) {
+       protected function formatPropertyId( $entityId ) {
                try {
                        return $this->propertyIdFormatter->format( $entityId );
                } catch ( FormattingException $ex ) {
diff --git 
a/extensions/Wikibase/repo/includes/EntityViewPlaceholderExpander.php 
b/extensions/Wikibase/repo/includes/EntityViewPlaceholderExpander.php
index 8ad5ae0..1455b82 100644
--- a/extensions/Wikibase/repo/includes/EntityViewPlaceholderExpander.php
+++ b/extensions/Wikibase/repo/includes/EntityViewPlaceholderExpander.php
@@ -219,7 +219,7 @@
         * @throws InvalidArgumentException
         * @return string HTML
         */
-       public function renderTermBox( EntityId $entityId, $revisionId ) {
+       public function renderTermBox( $entityId, $revisionId ) {
                $languages = $this->getExtraUserLanguages();
 
                if ( !$languages ) {
diff --git a/extensions/Wikibase/repo/includes/store/EntityPerPage.php 
b/extensions/Wikibase/repo/includes/store/EntityPerPage.php
index 1502411..0462636 100644
--- a/extensions/Wikibase/repo/includes/store/EntityPerPage.php
+++ b/extensions/Wikibase/repo/includes/store/EntityPerPage.php
@@ -27,7 +27,7 @@
         *
         * @throws InvalidArgumentException
         */
-       public function addEntityPage( EntityId $entityId, $pageId );
+       public function addEntityPage( $entityId, $pageId );
 
        /**
         * Adds a new link between an entity redirect and a page
@@ -38,7 +38,7 @@
         * @param int $pageId
         * @param EntityId $targetId
         */
-       public function addRedirectPage( EntityId $entityId, $pageId, EntityId 
$targetId );
+       public function addRedirectPage( $entityId, $pageId, $targetId );
 
        /**
         * Lists entities of the given type.
diff --git a/extensions/Wikibase/repo/includes/store/sql/EntityPerPageTable.php 
b/extensions/Wikibase/repo/includes/store/sql/EntityPerPageTable.php
index 7697d37..dcba318 100644
--- a/extensions/Wikibase/repo/includes/store/sql/EntityPerPageTable.php
+++ b/extensions/Wikibase/repo/includes/store/sql/EntityPerPageTable.php
@@ -53,7 +53,7 @@
         *
         * @throws InvalidArgumentException
         */
-       public function addEntityPage( EntityId $entityId, $pageId ) {
+       public function addEntityPage( $entityId, $pageId ) {
                $this->addRow( $entityId, $pageId );
        }
 
@@ -64,7 +64,7 @@
         * @param int $pageId
         * @param EntityId $targetId
         */
-       public function addRedirectPage( EntityId $entityId, $pageId, EntityId 
$targetId ) {
+       public function addRedirectPage( $entityId, $pageId, $targetId ) {
                $this->addRow( $entityId, $pageId, $targetId );
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/163037
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0acd2096d21bbcff18014fa006428932ce087aff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikidata
Gerrit-Branch: mw1.24-wmf21
Gerrit-Owner: Ori.livneh <o...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits