Hoo man has uploaded a new change for review.
https://gerrit.wikimedia.org/r/163061
Change subject: Fix unit test expected inline CSS
......................................................................
Fix unit test expected inline CSS
This changed in Scribunto with b970046f2e5
Change-Id: Ie2c381c0104d04e77accfd34c92275e1d52b9291
---
M tests/phpunit/includes/lua/InfoboxRenderTests.lua
1 file changed, 26 insertions(+), 26 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Capiunto
refs/changes/61/163061/1
diff --git a/tests/phpunit/includes/lua/InfoboxRenderTests.lua
b/tests/phpunit/includes/lua/InfoboxRenderTests.lua
index eb7a7d5..4f647e1 100644
--- a/tests/phpunit/includes/lua/InfoboxRenderTests.lua
+++ b/tests/phpunit/includes/lua/InfoboxRenderTests.lua
@@ -91,7 +91,7 @@
},
{ name = 'mw.capiunto.Infobox._render.renderWrapper 1', func =
testRenderWrapper, type='ToString',
args = { {} },
- expect = { '<table class="mw-capiunto-infobox" cellspacing="3"
style="border-spacing:3px;width:22em;"></table>' }
+ expect = { '<table class="mw-capiunto-infobox" cellspacing="3"
style="border-spacing:3px;width:22em"></table>' }
},
{ name = 'mw.capiunto.Infobox._render.renderWrapper 2', func =
testRenderWrapper, type='ToString',
args = { { isChild = true } },
@@ -105,40 +105,40 @@
args = { { isSubbox = true } },
expect = {
'<table class="mw-capiunto-infobox mw-capiunto-infobox-subbox"
cellspacing="3" ' ..
- 'style="border-spacing:3px;"></table>'
+ 'style="border-spacing:3px"></table>'
}
},
{ name = 'mw.capiunto.Infobox._render.renderHeader 1', func =
testRenderHeader, type='ToString',
args = { {}, 'foo' },
- expect = { '<tr><th colspan="2"
style="text-align:center;">foo</th></tr>' }
+ expect = { '<tr><th colspan="2"
style="text-align:center">foo</th></tr>' }
},
{ name = 'mw.capiunto.Infobox._render.renderHeader 2', func =
testRenderHeader, type='ToString',
args = { {}, 'foo', 'bar' },
- expect = { '<tr><th colspan="2" class="bar"
style="text-align:center;">foo</th></tr>' }
+ expect = { '<tr><th colspan="2" class="bar"
style="text-align:center">foo</th></tr>' }
},
{ name = 'mw.capiunto.Infobox._render.renderHeader 3', func =
testRenderHeader, type='ToString',
args = { { headerStyle = 'what:ever' }, 'foo', 'bar' },
- expect = { '<tr><th colspan="2" class="bar"
style="text-align:center;what:ever;">foo</th></tr>' }
+ expect = { '<tr><th colspan="2" class="bar"
style="text-align:center;what:ever">foo</th></tr>' }
},
{ name = 'mw.capiunto.Infobox._render.renderRow 1', func =
testRenderRow, type='ToString',
args = { {}, { data = 'foo' } },
- expect = { '<tr><td colspan="2"
style="text-align:center;">\nfoo</td></tr>' }
+ expect = { '<tr><td colspan="2"
style="text-align:center">\nfoo</td></tr>' }
},
{ name = 'mw.capiunto.Infobox._render.renderRow 2', func =
testRenderRow, type='ToString',
args = { {}, { data = 'foo', label = 'bar' } },
- expect = { '<tr><th scope="row"
style="text-align:left;">bar</th><td>\nfoo</td></tr>' }
+ expect = { '<tr><th scope="row"
style="text-align:left">bar</th><td>\nfoo</td></tr>' }
},
{ name = 'mw.capiunto.Infobox._render.renderRow 3', func =
testRenderRow, type='ToString',
args = { { labelStyle = 'a:b' }, { data = 'foo', label = 'bar' } },
- expect = { '<tr><th scope="row"
style="text-align:left;a:b;">bar</th><td>\nfoo</td></tr>' }
+ expect = { '<tr><th scope="row"
style="text-align:left;a:b">bar</th><td>\nfoo</td></tr>' }
},
{ name = 'mw.capiunto.Infobox._render.renderRow 4', func =
testRenderRow, type='ToString',
args = { {}, { data = 'foo', class='meh', dataStyle="a:b" } },
- expect = { '<tr><td colspan="2" class="meh"
style="text-align:center;a:b;">\nfoo</td></tr>' }
+ expect = { '<tr><td colspan="2" class="meh"
style="text-align:center;a:b">\nfoo</td></tr>' }
},
{ name = 'mw.capiunto.Infobox._render.renderWikitext 1', func =
testRenderWikitext, type='ToString',
args = { 'abc' },
- expect = { '<tr><td colspan="2"
style="text-align:center;">\nabc</td></tr>' }
+ expect = { '<tr><td colspan="2"
style="text-align:center">\nabc</td></tr>' }
},
{ name = 'mw.capiunto.Infobox._render.renderTitle 1', func =
testRenderTitle, type='ToString',
args = { { title = 'cd' } },
@@ -146,15 +146,15 @@
},
{ name = 'mw.capiunto.Infobox._render.renderTitle 2', func =
testRenderTitle, type='ToString',
args = { { title = 'cd', titleClass = 'ab', titleStyle =
'wikidata:awesome' } },
- expect = { '<caption class="ab"
style="wikidata:awesome;">cd</caption>' }
+ expect = { '<caption class="ab"
style="wikidata:awesome">cd</caption>' }
},
{ name = 'mw.capiunto.Infobox._render.renderSubHeaders 1', func =
testRenderSubHeader, type='ToString',
args = { { subHeaders = { { text = 'foo' } } } },
- expect = { '<tr><td colspan="2"
style="text-align:center;">\nfoo</td></tr>' }
+ expect = { '<tr><td colspan="2"
style="text-align:center">\nfoo</td></tr>' }
},
{ name = 'mw.capiunto.Infobox._render.renderSubHeaders 2', func =
testRenderSubHeader, type='ToString',
args = { { subHeaders = { { text = 'foo', style = 'a' } } } },
- expect = { '<tr><td colspan="2"
style="text-align:center;a;">\nfoo</td></tr>' }
+ expect = { '<tr><td colspan="2"
style="text-align:center;a">\nfoo</td></tr>' }
},
{ name = 'mw.capiunto.Infobox._render.renderTopRow 1', func =
testRenderTopRow, type='ToString',
args = { {} },
@@ -162,11 +162,11 @@
},
{ name = 'mw.capiunto.Infobox._render.renderTopRow 2', func =
testRenderTopRow, type='ToString',
args = { { top = 'foo' } },
- expect = { '<tr><th colspan="2"
style="font-weight:bold;text-align:center;font-size:125%;">foo</th></tr>' }
+ expect = { '<tr><th colspan="2"
style="font-weight:bold;text-align:center;font-size:125%">foo</th></tr>' }
},
{ name = 'mw.capiunto.Infobox._render.renderTopRow 3', func =
testRenderTopRow, type='ToString',
args = { { top = 'foo', topClass = 'a', topStyle='b' } },
- expect = { '<tr><th colspan="2" class="a"
style="font-weight:bold;text-align:center;font-size:125%;b;">foo</th></tr>' }
+ expect = { '<tr><th colspan="2" class="a"
style="font-weight:bold;text-align:center;font-size:125%;b">foo</th></tr>' }
},
{ name = 'mw.capiunto.Infobox._render.renderBottomRow 1', func =
testRenderBottomRow, type='ToString',
args = { {} },
@@ -174,11 +174,11 @@
},
{ name = 'mw.capiunto.Infobox._render.renderBottomRow 2', func =
testRenderBottomRow, type='ToString',
args = { { bottom = 'foo' } },
- expect = { '<tr><td colspan="2"
style="text-align:center;">\nfoo</td></tr>' }
+ expect = { '<tr><td colspan="2"
style="text-align:center">\nfoo</td></tr>' }
},
{ name = 'mw.capiunto.Infobox._render.renderBottomRow 2', func =
testRenderBottomRow, type='ToString',
args = { { bottom = 'foo', bottomClass = 'a', bottomStyle = 'b' } },
- expect = { '<tr><td colspan="2" class="a"
style="text-align:center;b;">\nfoo</td></tr>' }
+ expect = { '<tr><td colspan="2" class="a"
style="text-align:center;b">\nfoo</td></tr>' }
},
{ name = 'mw.capiunto.Infobox._render.renderImages 1', func =
testRenderImages, type='ToString',
args = { { } },
@@ -186,11 +186,11 @@
},
{ name = 'mw.capiunto.Infobox._render.renderImages 2', func =
testRenderImages, type='ToString',
args = { { captionStyle = 'a:b', images = { { image =
'[[File:Foo.bar]]', caption="a" } }, } },
- expect = { '<tr><td colspan="2"
style="text-align:center;">\n[[File:Foo.bar]]<br /><div
style="a:b;">a</div></td></tr>' }
+ expect = { '<tr><td colspan="2"
style="text-align:center">\n[[File:Foo.bar]]<br /><div
style="a:b">a</div></td></tr>' }
},
{ name = 'mw.capiunto.Infobox._render.renderImages 3', func =
testRenderImages, type='ToString',
args = { { imageStyle = 'a', imageClass="b", images = { { image =
'img' } }, } },
- expect = { '<tr><td colspan="2" class="b"
style="text-align:center;a;">\nimg</td></tr>' }
+ expect = { '<tr><td colspan="2" class="b"
style="text-align:center;a">\nimg</td></tr>' }
},
{ name = 'mw.capiunto.Infobox._render.renderImages 4', func =
testRenderImages, type='ToString',
args =
@@ -200,9 +200,9 @@
{ image = '[[File:B]]', caption = 'C', class =
'D-Class' },
} } },
expect = {
- '<tr><td colspan="2"
style="text-align:center;">\n[[File:Foo.bar]]</td></tr>' ..
- '<tr><td colspan="2" style="text-align:center;">\n[[File:A]]<br
/><div>Capt.</div></td></tr>' ..
- '<tr class="D-Class"><td colspan="2"
style="text-align:center;">\n[[File:B]]<br /><div>C</div></td></tr>'
+ '<tr><td colspan="2"
style="text-align:center">\n[[File:Foo.bar]]</td></tr>' ..
+ '<tr><td colspan="2" style="text-align:center">\n[[File:A]]<br
/><div>Capt.</div></td></tr>' ..
+ '<tr class="D-Class"><td colspan="2"
style="text-align:center">\n[[File:B]]<br /><div>C</div></td></tr>'
}
},
{ name = 'mw.capiunto.Infobox._render.renderRows 1', func =
testRenderRows, type='ToString',
@@ -218,10 +218,10 @@
{ data = 'foo', class='meh' },
}, labelStyle="a:b" } },
expect = {
- '<tr><th scope="row"
style="text-align:left;a:b;">bar</th><td>\nfoo</td></tr>' ..
- '<tr><th colspan="2" class="bar"
style="text-align:center;">foo</th></tr>' ..
- '<tr><td colspan="2"
style="text-align:center;">\nBerlin</td></tr>' ..
- '<tr><td colspan="2" class="meh"
style="text-align:center;">\nfoo</td></tr>'
+ '<tr><th scope="row"
style="text-align:left;a:b">bar</th><td>\nfoo</td></tr>' ..
+ '<tr><th colspan="2" class="bar"
style="text-align:center">foo</th></tr>' ..
+ '<tr><td colspan="2"
style="text-align:center">\nBerlin</td></tr>' ..
+ '<tr><td colspan="2" class="meh"
style="text-align:center">\nfoo</td></tr>'
}
},
}
--
To view, visit https://gerrit.wikimedia.org/r/163061
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2c381c0104d04e77accfd34c92275e1d52b9291
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Capiunto
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
