Vikassy has uploaded a new change for review.
https://gerrit.wikimedia.org/r/163185
Change subject: [BrowserTest] Fixed failing language screenshot scenarios
......................................................................
[BrowserTest] Fixed failing language screenshot scenarios
Bug #71298
Change-Id: Ifcd52935e782e292f9289a72d5e7c4ad12921b4b
---
M modules/ve-mw/tests/browser/features/language_screenshot.feature
M
modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
M modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
3 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/85/163185/1
diff --git a/modules/ve-mw/tests/browser/features/language_screenshot.feature
b/modules/ve-mw/tests/browser/features/language_screenshot.feature
index f5390d4..d449fd1 100644
--- a/modules/ve-mw/tests/browser/features/language_screenshot.feature
+++ b/modules/ve-mw/tests/browser/features/language_screenshot.feature
@@ -38,6 +38,7 @@
When I click Save page
Then I should see save changes dialog box
+ @language_screenshot
Scenario: VisualEditor_Page_Settings
Given I am editing language screenshot page
And I click the hamburger menu
@@ -137,6 +138,7 @@
And I type a formula
Then I should see the formula insertion menu
+ @language_screenshot
Scenario: VisualEditor_cancel_save
Given I am logged in
When I am edit language screenshot page with Testing toolbar
diff --git
a/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
b/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
index d95cc46..28e7d98 100644
---
a/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
+++
b/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
@@ -188,7 +188,7 @@
capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
[@current_page.iframe_element], nil, 0)
-
capture_screenshot("VisualEditor_Page_Settings_Redirects-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
[@current_page.page_settings_heading_element,
@current_page.prevent_redirect_element,
@current_page.page_settings_gap_element], @current_page.iframe_element, 0)
+
capture_screenshot("VisualEditor_Page_Settings_Redirects-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
[@current_page.page_settings_heading_element,
@current_page.prevent_redirect_element], @current_page.iframe_element, 0)
capture_screenshot("VisualEditor_Page_Settings_TOC-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
[@current_page.table_of_contents_element], @current_page.iframe_element, 0)
diff --git
a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
index 78366c1..dfa5316 100644
--- a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
+++ b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
@@ -156,7 +156,7 @@
text_field(:transclusion_textfield, index: 0, frame: frame)
span(:existing_reference, text: "Use an existing reference", frame: frame)
div(:extension_reference, class: "ve-ui-mwReferenceResultWidget-shield",
frame: frame)
- div(:page_settings_heading, class: "oo-ui-labelElement-label", frame:
frame)
+ span(:page_settings_heading, css: "div.oo-ui-fieldsetLayout >
span.oo-ui-labelElement-label", frame: frame)
div(:redirect_page_option, class: "oo-ui-layout oo-ui-labelElement
oo-ui-fieldLayout oo-ui-fieldLayout-align-inline", frame: frame)
div(:target_redirect, class: "oo-ui-layout oo-ui-fieldLayout
oo-ui-fieldLayout-align-top oo-ui-fieldLayout-disabled", frame: frame)
div(:prevent_redirect, class: "oo-ui-layout oo-ui-labelElement
oo-ui-fieldLayout oo-ui-fieldLayout-align-inline oo-ui-fieldLayout-disabled",
frame: frame)
@@ -168,7 +168,6 @@
a(:insert_media, css: "div.oo-ui-processDialog-actions-primary >
div.oo-ui-buttonElement-frameless > a", frame: frame)
text_area(:formula_area, class: "oo-ui-ltr", frame: frame)
div(:settings_apply_button, class: "oo-ui-processDialog-actions-primary",
frame: frame)
- div(:page_settings_gap, class: "oo-ui-layout oo-ui-panelLayout
oo-ui-panelLayout-scrollable oo-ui-panelLayout-expanded oo-ui-stackLayout
oo-ui-bookletLayout-stackLayout", frame: frame)
end
# not having beta warning makes iframes off by one
--
To view, visit https://gerrit.wikimedia.org/r/163185
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifcd52935e782e292f9289a72d5e7c4ad12921b4b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Vikassy <vikasyaligar...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
