Deskana has uploaded a new change for review.
https://gerrit.wikimedia.org/r/163453
Change subject: Remove prompt when the user refreshes all saved pages.
......................................................................
Remove prompt when the user refreshes all saved pages.
Now that the process of refreshing saved pages is synchronous and can be
aborted by the user, the prompt asking the user if they want to refresh their
saved pages is unnecessary. This patch removes that prompt.
Change-Id: I6f50d3ef03e93101c96c3648f9a7388ce5af5be6
---
M wikipedia/src/main/java/org/wikipedia/savedpages/SavedPagesActivity.java
1 file changed, 1 insertion(+), 14 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/53/163453/1
diff --git
a/wikipedia/src/main/java/org/wikipedia/savedpages/SavedPagesActivity.java
b/wikipedia/src/main/java/org/wikipedia/savedpages/SavedPagesActivity.java
index 944bc85..7ad6c95 100644
--- a/wikipedia/src/main/java/org/wikipedia/savedpages/SavedPagesActivity.java
+++ b/wikipedia/src/main/java/org/wikipedia/savedpages/SavedPagesActivity.java
@@ -278,7 +278,7 @@
finish();
return true;
case R.id.menu_refresh_all_saved_pages:
- promptToRefreshAll();
+ refreshAll();
return true;
case R.id.menu_clear_all_saved_pages:
promptToDeleteAll();
@@ -286,19 +286,6 @@
default:
throw new RuntimeException("Unknown menu item clicked!");
}
- }
-
- private void promptToRefreshAll() {
- AlertDialog.Builder builder = new AlertDialog.Builder(this);
- builder.setMessage(R.string.dialog_prompt_refresh_all_saved_pages);
- builder.setPositiveButton(R.string.yes, new
DialogInterface.OnClickListener() {
- @Override
- public void onClick(DialogInterface dialog, int which) {
- refreshAll();
- }
- });
- builder.setNegativeButton(R.string.no, null);
- builder.create().show();
}
private void promptToDeleteAll() {
--
To view, visit https://gerrit.wikimedia.org/r/163453
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f50d3ef03e93101c96c3648f9a7388ce5af5be6
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Deskana <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
