Krinkle has submitted this change and it was merged. Change subject: (bug 41349) mediawiki.searchSuggest: Reorder code + fix selectors ......................................................................
(bug 41349) mediawiki.searchSuggest: Reorder code + fix selectors The code for general suggestions wouldn't run at all if no primary search box was found. I moved this check down, to where the box is actually needed. The selectors were hardcoded with no explanation. Added comments, added selector .mw-searchInput (as a generic one to be used by skins with multiple search boxes, currently only CologneBlue). Change-Id: Ie22fb66926688b0fdb28a121cfa0fb61ead0246d --- M resources/mediawiki/mediawiki.searchSuggest.js 1 file changed, 26 insertions(+), 15 deletions(-) Approvals: Krinkle: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/29821 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie22fb66926688b0fdb28a121cfa0fb61ead0246d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: REL1_20 Gerrit-Owner: Krinkle <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: Matmarex <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
