jenkins-bot has submitted this change and it was merged.
Change subject: LqtView::simplePageMove(): Throw a ThrottledError directly
......................................................................
LqtView::simplePageMove(): Throw a ThrottledError directly
Also removed the return statements; the return value is not
documented or used for anything.
Change-Id: Ib317a90b0275ee4b6a95b90a3292a29791f64045
---
M classes/View.php
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
Nikerabbit: Looks good to me, approved
jenkins-bot: Verified
diff --git a/classes/View.php b/classes/View.php
index e6aa219..95b54a3 100644
--- a/classes/View.php
+++ b/classes/View.php
@@ -1118,8 +1118,7 @@
*/
function simplePageMove( $old_title, $new_subject, $reason ) {
if ( $this->user->pingLimiter( 'move' ) ) {
- $this->out->rateLimited();
- return false;
+ throw new ThrottledError;
}
# Variables beginning with 'o' for old article 'n' for new
article
@@ -1136,8 +1135,6 @@
# Move the talk page if relevant, if it exists, and if we've
been told to
// TODO we need to implement correct moving of talk pages
everywhere later.
// Snipped.
-
- return true;
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/163546
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib317a90b0275ee4b6a95b90a3292a29791f64045
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LiquidThreads
Gerrit-Branch: master
Gerrit-Owner: PleaseStand <pleasest...@live.com>
Gerrit-Reviewer: IAlex <coderev...@emsenhuber.ch>
Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
