jenkins-bot has submitted this change and it was merged.
Change subject: Don't yet include statements yet on properties
......................................................................
Don't yet include statements yet on properties
These are mistakenly being added in the JS entityview,
but shouldn't be yet as not possible yet to actually
save them, among other issues still to resolve.
Change-Id: I13166578fcaea99f901901abf3c8531f18c82df1
(cherry picked from commit 81badf300de1663f54847e5af7519afcca2a0fb5)
---
M lib/resources/jquery.wikibase/jquery.wikibase.entityview.js
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Aude: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.entityview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.entityview.js
index bb41339..962abfb 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.entityview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.entityview.js
@@ -98,8 +98,12 @@
this._initDescription();
this._initAliases();
this._initFingerprints();
- this._initClaims();
- this._initSiteLinks();
+
+ // TODO: Have an itemview and propertyview instead of ugly hack
here.
+ if ( this.options.value.getDataType() === 'wikibase-item' ) {
+ this._initClaims();
+ this._initSiteLinks();
+ }
this._attachEventHandlers();
},
--
To view, visit https://gerrit.wikimedia.org/r/164327
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I13166578fcaea99f901901abf3c8531f18c82df1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: wmf/1.25wmf1
Gerrit-Owner: Aude <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
