Prtksxna has uploaded a new change for review.
https://gerrit.wikimedia.org/r/164376
Change subject: buttons: Revert to old focus state
......................................................................
buttons: Revert to old focus state
Reverts the following patches:
* Ibd75f7caaf5f34d8bcc53381335a048cede26950
* Ide6174c5da3a04b8e6c4370fbc191783e976f6ee
The implementation of the new design specification
is imperfect. Zooming into the element shows that
the borders aren't equal on all sides and there is
a different colored border on the top and bottom.
Change-Id: I6badefcab971de162f9553a1fb1475f57b868dab
---
M resources/src/mediawiki.less/mediawiki.ui/mixins.less
1 file changed, 4 insertions(+), 24 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/76/164376/1
diff --git a/resources/src/mediawiki.less/mediawiki.ui/mixins.less
b/resources/src/mediawiki.less/mediawiki.ui/mixins.less
index 17fcc60..2c0f940 100644
--- a/resources/src/mediawiki.less/mediawiki.ui/mixins.less
+++ b/resources/src/mediawiki.less/mediawiki.ui/mixins.less
@@ -36,21 +36,11 @@
.button-colors(@bgColor) {
background: @bgColor;
- &:hover {
+ &:hover,
+ &:focus {
// The inner bottom bevel should match the active background
color.
box-shadow: 0 1px rgba(0, 0, 0, 10%), inset 0 -3px rgba(0, 0,
0, 20%);
border-bottom-color: mix(#000, @bgColor, 20%);
- }
-
- &:focus {
- box-shadow:inset 0px 0px 0px 3px rgba(0, 0, 0, 20%);
- outline: none;
-
- // remove outline in Firefox
- &::-moz-focus-inner {
- border-color: transparent;
- }
-
}
&:active,
@@ -107,21 +97,11 @@
// constructive/progressive/destructive color on hover and active.
color: @colorButtonText;
- &:hover {
+ &:hover,
+ &:focus {
// lessphp doesn't implement tint, see above
// color: tint(@textColor, 20%);
color: mix(#fff, @textColor, 20%);
- }
-
- &:focus {
- box-shadow:inset 0px 0px 0px 3px rgba(0, 0, 0, 20%);
- outline: none;
-
- // remove outline in Firefox
- &::-moz-focus-inner {
- border-color: transparent;
- }
-
}
&:active,
--
To view, visit https://gerrit.wikimedia.org/r/164376
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6badefcab971de162f9553a1fb1475f57b868dab
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
