Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/164417

Change subject: webperf::navtiming: Handle SaveTiming events
......................................................................

webperf::navtiming: Handle SaveTiming events

Report SaveTiming events logged by the NavigationTiming extension to Graphite.

Change-Id: Iad9163478dc78a74a40049442a1f32816f704ba7
---
M modules/webperf/files/navtiming.py
1 file changed, 17 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/17/164417/1

diff --git a/modules/webperf/files/navtiming.py 
b/modules/webperf/files/navtiming.py
index d13bed1..cd360b1 100644
--- a/modules/webperf/files/navtiming.py
+++ b/modules/webperf/files/navtiming.py
@@ -50,9 +50,16 @@
     sock.sendto(stat.encode('utf-8'), addr)
 
 
-for meta in iter(zsock.recv_json, ''):
-    if meta['schema'] != 'NavigationTiming':
-        continue
+def handle_save_timing(meta):
+    event = meta['event']
+    duration = event['duration']
+    runtime = event['runtime']
+    if duration > 0 and duration < 60000:
+        stat = 'mw.performance.save.%s:%s|ms' % (runtime, duration)
+        sock.sendto(stat.encode('utf-8'), addr)
+
+
+def handle_navigation_timing(meta):
     event = meta['event']
 
     if 'fetchStart' in event:
@@ -92,3 +99,10 @@
                 dispatch_stat(runtime, metric, site, auth, value)
                 dispatch_stat(runtime, metric, site, 'overall', value)
                 dispatch_stat(runtime, metric, 'overall', value)
+
+
+for meta in iter(zsock.recv_json, ''):
+    if meta['schema'] == 'NavigationTiming':
+        handle_navigation_timing(meta)
+    if meta['schema'] == 'SaveTiming':
+        handle_save_timing(meta)

-- 
To view, visit https://gerrit.wikimedia.org/r/164417
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad9163478dc78a74a40049442a1f32816f704ba7
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to