jenkins-bot has submitted this change and it was merged.
Change subject: Special:MediaStatistics: data-sort-value also for number of
files
......................................................................
Special:MediaStatistics: data-sort-value also for number of files
The column "Number of files" is sortable, but does not contains plain
numbers, so it needs a data-sort-value to allow js to sort correct.
Change-Id: I9b7232b755dc8dab2cf04682103085273dada737
---
M includes/specials/SpecialMediaStatistics.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Brian Wolff: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialMediaStatistics.php
b/includes/specials/SpecialMediaStatistics.php
index 3fd84138e..1084482 100644
--- a/includes/specials/SpecialMediaStatistics.php
+++ b/includes/specials/SpecialMediaStatistics.php
@@ -153,7 +153,8 @@
);
$row .= Html::rawElement(
'td',
- array(),
+ // Make sure js sorts it in numeric order
+ array( 'data-sort-value' => $count ),
$this->msg( 'mediastatistics-nfiles' )
->numParams( $count )
/** @todo Check to be sure this really should
have number formatting */
--
To view, visit https://gerrit.wikimedia.org/r/164416
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b7232b755dc8dab2cf04682103085273dada737
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Brian Wolff <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
