jenkins-bot has submitted this change and it was merged.
Change subject: Revert "buttons: Update focus for quiet buttons"
......................................................................
Revert "buttons: Update focus for quiet buttons"
This reverts commit 778ecee16fe38c27c4e313a5bea9c65f6bb65a53.
The implementation of the new design specification
is imperfect. Zooming into the element shows that
the borders aren't equal on all sides and there is
a different colored border on the top and bottom.
Change-Id: Ic8c40498abe9201bdf4e740737467d2d88211442
---
M resources/src/mediawiki.less/mediawiki.ui/mixins.less
1 file changed, 3 insertions(+), 13 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/src/mediawiki.less/mediawiki.ui/mixins.less
b/resources/src/mediawiki.less/mediawiki.ui/mixins.less
index 17fcc60..d3220cc 100644
--- a/resources/src/mediawiki.less/mediawiki.ui/mixins.less
+++ b/resources/src/mediawiki.less/mediawiki.ui/mixins.less
@@ -44,8 +44,8 @@
&:focus {
box-shadow:inset 0px 0px 0px 3px rgba(0, 0, 0, 20%);
+// box-shadow: 0 1px rgba(0, 0, 0, 10%), inset 0 -3px rgba(0, 0,
0, 20%);
outline: none;
-
// remove outline in Firefox
&::-moz-focus-inner {
border-color: transparent;
@@ -107,21 +107,11 @@
// constructive/progressive/destructive color on hover and active.
color: @colorButtonText;
- &:hover {
+ &:hover,
+ &:focus {
// lessphp doesn't implement tint, see above
// color: tint(@textColor, 20%);
color: mix(#fff, @textColor, 20%);
- }
-
- &:focus {
- box-shadow:inset 0px 0px 0px 3px rgba(0, 0, 0, 20%);
- outline: none;
-
- // remove outline in Firefox
- &::-moz-focus-inner {
- border-color: transparent;
- }
-
}
&:active,
--
To view, visit https://gerrit.wikimedia.org/r/164671
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8c40498abe9201bdf4e740737467d2d88211442
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
