Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/164955
Change subject: Remove unused code from snakview
......................................................................
Remove unused code from snakview
Change-Id: Ia7fb2ae2497961d83a94324d0fc4ca3f6f683d70
---
M lib/resources/jquery.wikibase/snakview/snakview.js
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/55/164955/1
diff --git a/lib/resources/jquery.wikibase/snakview/snakview.js
b/lib/resources/jquery.wikibase/snakview/snakview.js
index 555fddd..862f710 100644
--- a/lib/resources/jquery.wikibase/snakview/snakview.js
+++ b/lib/resources/jquery.wikibase/snakview/snakview.js
@@ -638,7 +638,7 @@
*
* @since 0.4
*
- * @param {String|null} snakType
+ * @param {String|null} [snakType]
* @return String|null
*/
snakType: function( snakType ) {
@@ -671,7 +671,6 @@
*/
_updateVariation: function() {
var variationsFactory = $.wikibase.snakview.variations,
- variationType,
snakType = this._snakType,
VariationConstructor = variationsFactory.getVariation(
snakType );
@@ -694,7 +693,6 @@
this._entityStore,
this._valueViewBuilder
);
- variationType =
this._variation.variationSnakConstructor.TYPE;
}
},
--
To view, visit https://gerrit.wikimedia.org/r/164955
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7fb2ae2497961d83a94324d0fc4ca3f6f683d70
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
