jenkins-bot has submitted this change and it was merged.
Change subject: Removed isZeroSite()'s caching
......................................................................
Removed isZeroSite()'s caching
Change-Id: I1d1611d1f959bfd33cce8e5d42affd5a634faf77
---
M includes/PageRendering.php
1 file changed, 3 insertions(+), 7 deletions(-)
Approvals:
Dr0ptp4kt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/PageRendering.php b/includes/PageRendering.php
index 88bcb95..1dd2645 100644
--- a/includes/PageRendering.php
+++ b/includes/PageRendering.php
@@ -651,13 +651,9 @@
* @return bool
*/
private function isZeroSite() {
- static $isZero = null;
- if ( $isZero === null ) {
- $info = $this->getWikiInfo();
- // @FIXME: this check should only see if this is a
mobileview, the rest is a check in partner's config
- $isZero = $info[2] === 'wikipedia' &&
MobileContext::singleton()->shouldDisplayMobileView();
- }
- return $isZero;
+ $info = $this->getWikiInfo();
+ // @FIXME: this check should only see if this is a mobileview,
the rest is a check in partner's config
+ return $info[2] === 'wikipedia' &&
MobileContext::singleton()->shouldDisplayMobileView();
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/164519
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d1611d1f959bfd33cce8e5d42affd5a634faf77
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ZeroBanner
Gerrit-Branch: master
Gerrit-Owner: Yurik <[email protected]>
Gerrit-Reviewer: Dr0ptp4kt <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
