Brion VIBBER has submitted this change and it was merged.
Change subject: Protection against nil title or domain crashes.
......................................................................
Protection against nil title or domain crashes.
Change-Id: I26aa76563b8d2cbee9efa64cebdd6d1a1b7b4ae2
---
M wikipedia/View Controllers/WebView/WebViewController.m
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Brion VIBBER: Verified; Looks good to me, approved
diff --git a/wikipedia/View Controllers/WebView/WebViewController.m
b/wikipedia/View Controllers/WebView/WebViewController.m
index c84c0c0..bdc20b0 100644
--- a/wikipedia/View Controllers/WebView/WebViewController.m
+++ b/wikipedia/View Controllers/WebView/WebViewController.m
@@ -1847,7 +1847,7 @@
Article *article = (Article *)[articleDataContext_.mainContext
objectWithID:articleID];
- if (!article) return;
+ if (!article || !article.title || !article.domain) return;
[SessionSingleton sharedInstance].currentArticleTitle = article.title;
[SessionSingleton sharedInstance].currentArticleDomain = article.domain;
MWLanguageInfo *languageInfo = [MWLanguageInfo
languageInfoForCode:article.domain];
--
To view, visit https://gerrit.wikimedia.org/r/165150
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26aa76563b8d2cbee9efa64cebdd6d1a1b7b4ae2
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mhurd <mh...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
