Mattflaschen has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/165435

Change subject: Enable XDebug with HHVM
......................................................................

Enable XDebug with HHVM

This works for me, but not reliably.  For example, I get
https://github.com/facebook/hhvm/issues/3926 and not all debugging
commands seem to respond correctly.

However, it should not interfere with the experience if you are not
using XDebug (i.e. if the browser cookie is not set).

Thus, I think it's mergable so people can continue to attempt to use
it and troubleshoot the debugger itself.

Bug: 71777
Change-Id: I2e5818012e7bd0d52be8a1eb2a02b96bdb341c6d
---
M puppet/hieradata/common.yaml
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vagrant 
refs/changes/35/165435/1

diff --git a/puppet/hieradata/common.yaml b/puppet/hieradata/common.yaml
index 7917d81..4ba578b 100644
--- a/puppet/hieradata/common.yaml
+++ b/puppet/hieradata/common.yaml
@@ -75,6 +75,11 @@
       slow_query_threshold: 300000
 hhvm::fcgi_settings:
   max_execution_time: 180
+  hhvm:
+    xdebug-not-done:
+      enable: 1
+      remote_connect_back: 1
+      remote_enable: 1
 hhvm::logroot: /vagrant/logs
 
 mathoid::base_path: /vagrant/mathoid

-- 
To view, visit https://gerrit.wikimedia.org/r/165435
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e5818012e7bd0d52be8a1eb2a02b96bdb341c6d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <mflasc...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to