jenkins-bot has submitted this change and it was merged.
Change subject: Fix varname type in test
......................................................................
Fix varname type in test
Change-Id: I3cf623a8348a328479d9956408ea64e059262f8d
---
M tests/phpunit/Collection/RevisionCollectionPermissionsTest.php
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Matthias Mullie: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/phpunit/Collection/RevisionCollectionPermissionsTest.php
b/tests/phpunit/Collection/RevisionCollectionPermissionsTest.php
index 35f67c4..e95fa58 100644
--- a/tests/phpunit/Collection/RevisionCollectionPermissionsTest.php
+++ b/tests/phpunit/Collection/RevisionCollectionPermissionsTest.php
@@ -149,7 +149,7 @@
/**
* @dataProvider permissionsProvider
*/
- public function testPermissions( User $user, $permisisonAction,
$actions ) {
+ public function testPermissions( User $user, $permissionAction,
$actions ) {
$permissions = new RevisionActionPermissions( $this->actions,
$user );
// we'll have to process this in 2 steps: first do all of the
actions,
@@ -174,8 +174,8 @@
$revision = array_shift( $revisions );
$this->assertEquals(
$expected,
- $permissions->isAllowed( $revision,
$permisisonAction ),
- 'User ' . $user->getName() . ' should ' . (
$expected ? '' : 'not ' ) . 'be allowed action ' . $permisisonAction . ' on
revision ' . key( $action ) . ' : ' . $debug . ' : ' . json_encode(
$revision::toStorageRow( $revision ) )
+ $permissions->isAllowed( $revision,
$permissionAction ),
+ 'User ' . $user->getName() . ' should ' . (
$expected ? '' : 'not ' ) . 'be allowed action ' . $permissionAction . ' on
revision ' . key( $action ) . ' : ' . $debug . ' : ' . json_encode(
$revision::toStorageRow( $revision ) )
);
}
}
--
To view, visit https://gerrit.wikimedia.org/r/165470
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3cf623a8348a328479d9956408ea64e059262f8d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
