jenkins-bot has submitted this change and it was merged. Change subject: Fix ImageMetrics schema ......................................................................
Fix ImageMetrics schema https://meta.wikimedia.org/w/index.php?diff=10078363 Fixes two issues: * some fields which were previously marked integer can have higher precision * non-required numeric EventLogging fields are not happy with null Change-Id: I7acba21690d6feb3af9e3f635d581cf242295d04 --- M ImageMetrics.php M resources/ext.imageMetrics.js 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Gilles: Looks good to me, approved jenkins-bot: Verified diff --git a/ImageMetrics.php b/ImageMetrics.php index 63e96a4..e507fc0 100644 --- a/ImageMetrics.php +++ b/ImageMetrics.php @@ -30,7 +30,7 @@ $wgExtensionFunctions[] = function () { global $wgEventLoggingSchemas; - $wgEventLoggingSchemas['ImageMetricsLoadingTime'] = 9673571; + $wgEventLoggingSchemas['ImageMetricsLoadingTime'] = 10078363; }; diff --git a/resources/ext.imageMetrics.js b/resources/ext.imageMetrics.js index ffebc8f..d390e33 100644 --- a/resources/ext.imageMetrics.js +++ b/resources/ext.imageMetrics.js @@ -144,7 +144,7 @@ if ( timing ) { data.ownLoadingTime = timing.duration; data.fullLoadingTime = timing.responseEnd; - data.fetchDelay = timing.responseStart ? ( timing.responseStart - timing.startTime ) : null; + data.fetchDelay = timing.responseStart ? ( timing.responseStart - timing.startTime ) : undefined; } }; -- To view, visit https://gerrit.wikimedia.org/r/164427 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7acba21690d6feb3af9e3f635d581cf242295d04 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ImageMetrics Gerrit-Branch: master Gerrit-Owner: Gergő Tisza <gti...@wikimedia.org> Gerrit-Reviewer: Gergő Tisza <gti...@wikimedia.org> Gerrit-Reviewer: Gilles <gdu...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
