Manybubbles has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165516
Change subject: More javadoc
......................................................................
More javadoc
Change-Id: If201acfa8a376b6691640e499f2ed82a7eb22185
---
M src/main/java/org/wikimedia/search/extra/util/FieldValues.java
M src/main/java/org/wikimedia/search/extra/util/Functions.java
2 files changed, 10 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/search/extra
refs/changes/16/165516/1
diff --git a/src/main/java/org/wikimedia/search/extra/util/FieldValues.java
b/src/main/java/org/wikimedia/search/extra/util/FieldValues.java
index 7158a54..dc16f68 100644
--- a/src/main/java/org/wikimedia/search/extra/util/FieldValues.java
+++ b/src/main/java/org/wikimedia/search/extra/util/FieldValues.java
@@ -14,11 +14,17 @@
import org.elasticsearch.index.fieldvisitor.CustomFieldsVisitor;
import org.elasticsearch.index.fieldvisitor.JustSourceFieldsVisitor;
+/**
+ * Hub for fetching field values.
+ */
public abstract class FieldValues {
/**
* Loads field values.
*/
public interface Loader {
+ /**
+ * Load the value of the string at path from reader for docId.
+ */
List<String> load(String path, IndexReader reader, int docId) throws
IOException;
}
diff --git a/src/main/java/org/wikimedia/search/extra/util/Functions.java
b/src/main/java/org/wikimedia/search/extra/util/Functions.java
index 9f6ea87..2790df3 100644
--- a/src/main/java/org/wikimedia/search/extra/util/Functions.java
+++ b/src/main/java/org/wikimedia/search/extra/util/Functions.java
@@ -6,6 +6,10 @@
* Some useful functions.
*/
public class Functions {
+ /**
+ * Call toString on the provided object. This normally comes with Guava but
+ * Elasticsearch shades it and that somehow makes it invisible.
+ */
public static Function<Object, String> toStringFunction() {
return TO_STRING;
}
@@ -14,10 +18,6 @@
// Utils class
}
- /**
- * Call toString on the provided object. This normally comes with Guava but
- * Elasticsearch shades it and that somehow makes it invisible.
- */
private static final Function<Object, String> TO_STRING = new
Function<Object, String>() {
@Override
public String apply(Object obj) {
--
To view, visit https://gerrit.wikimedia.org/r/165516
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If201acfa8a376b6691640e499f2ed82a7eb22185
Gerrit-PatchSet: 1
Gerrit-Project: search/extra
Gerrit-Branch: master
Gerrit-Owner: Manybubbles <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
