Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/165533

Change subject: Hygiene: Use jQuery each instead
......................................................................

Hygiene: Use jQuery each instead

forEach doesn't have as good support

Change-Id: If84f6acca9dde18fb001a54d39188688b6f73ff6
---
M javascripts/common/View.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Mantle 
refs/changes/33/165533/1

diff --git a/javascripts/common/View.js b/javascripts/common/View.js
index db28167..c929a00 100644
--- a/javascripts/common/View.js
+++ b/javascripts/common/View.js
@@ -157,7 +157,7 @@
                }
        } );
 
-       [
+       $.each( [
                'append',
                'prepend',
                'appendTo',
@@ -168,7 +168,7 @@
                'insertBefore',
                'remove',
                'detach'
-       ].forEach( function( prop ) {
+       ], function( i, prop ) {
                View.prototype[prop] = function() {
                        this.$el[prop].apply( this.$el, arguments );
                        return this;

-- 
To view, visit https://gerrit.wikimedia.org/r/165533
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If84f6acca9dde18fb001a54d39188688b6f73ff6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Mantle
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to