jenkins-bot has submitted this change and it was merged.
Change subject: Use `inline` content disposition, instead of `attachment`.
......................................................................
Use `inline` content disposition, instead of `attachment`.
This will cause most browsers to open the PDF in the browser, instead of
automatically downloading it. Users seem to prefer this behavior.
Change-Id: Iadc0ff6deeb6a24f2474b173aab996661827c4d5
---
M lib/JobDetails.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Cscott: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/JobDetails.js b/lib/JobDetails.js
index 25fce42..33fc4f0 100644
--- a/lib/JobDetails.js
+++ b/lib/JobDetails.js
@@ -142,7 +142,7 @@
this.content_type = type;
// http://tools.ietf.org/html/rfc6266
var encodedName = encodeURIComponent(name);
- this.content_disposition = 'attachment; ' +
+ this.content_disposition = 'inline; ' +
'filename="' + encodedName + '"; ' +
"filename*=utf-8''" + encodedName;
this.content_length = length;
--
To view, visit https://gerrit.wikimedia.org/r/165390
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iadc0ff6deeb6a24f2474b173aab996661827c4d5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Collection/OfflineContentGenerator
Gerrit-Branch: master
Gerrit-Owner: Cscott <[email protected]>
Gerrit-Reviewer: Cscott <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
