jenkins-bot has submitted this change and it was merged.
Change subject: Followup 78e3a91: can't assign getValue() to $textarea, oops
......................................................................
Followup 78e3a91: can't assign getValue() to $textarea, oops
Well spotted, Ed.
Change-Id: Ic3ce07591130d59fb2da5df2e410f39f672c71e1
---
M modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
index 13e72c4..bfdc37f 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
@@ -157,7 +157,8 @@
this.actions.setMode( 'save' );
// HACK: FF needs *another* defer
setTimeout( function () {
- var $textarea =
dialog.editSummaryInput.getValue();
+ // FIXME we need to add features to
OO.ui.TextInputWidget so we don't need to access .$input
+ var $textarea = dialog.editSummaryInput.$input;
$textarea[0].focus();
// If message has be pre-filled (e.g. section
edit), move cursor to end
if ( $textarea.val() !== '' ) {
--
To view, visit https://gerrit.wikimedia.org/r/165606
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3ce07591130d59fb2da5df2e410f39f672c71e1
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
