Jeroen De Dauw has submitted this change and it was merged. Change subject: Stop using aliases outside Wikibase namespace ......................................................................
Stop using aliases outside Wikibase namespace This is split from I687c61c. Change-Id: I10d7c3a81f2ce00d82e79a50f715c82a0211f3be --- M repo/tests/phpunit/includes/ChangeOp/ChangeOpTestMockProvider.php M repo/tests/phpunit/includes/EntityModificationTestHelper.php M repo/tests/phpunit/includes/api/RemoveReferencesTest.php 3 files changed, 6 insertions(+), 6 deletions(-) Approvals: Jeroen De Dauw: Looks good to me, approved diff --git a/repo/tests/phpunit/includes/ChangeOp/ChangeOpTestMockProvider.php b/repo/tests/phpunit/includes/ChangeOp/ChangeOpTestMockProvider.php index 682ed91..33b40b4 100644 --- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpTestMockProvider.php +++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpTestMockProvider.php @@ -14,17 +14,17 @@ use ValueValidators\Result; use ValueValidators\ValueValidator; use Wikibase\DataModel\Claim\ClaimGuidParser; -use Wikibase\DataModel\Claim\Statement; use Wikibase\DataModel\Entity\Entity; use Wikibase\DataModel\Entity\EntityId; use Wikibase\DataModel\Entity\Item; +use Wikibase\DataModel\Entity\PropertyDataTypeLookup; use Wikibase\DataModel\Entity\PropertyId; use Wikibase\DataModel\Snak\PropertyNoValueSnak; use Wikibase\DataModel\Snak\PropertyValueSnak; +use Wikibase\DataModel\Statement\Statement; use Wikibase\LabelDescriptionDuplicateDetector; use Wikibase\Lib\ClaimGuidGenerator; use Wikibase\Lib\ClaimGuidValidator; -use Wikibase\DataModel\Entity\PropertyDataTypeLookup; use Wikibase\Lib\Store\SiteLinkCache; use Wikibase\Validators\CompositeFingerprintValidator; use Wikibase\Validators\CompositeValidator; @@ -511,4 +511,5 @@ return $mock; } + } diff --git a/repo/tests/phpunit/includes/EntityModificationTestHelper.php b/repo/tests/phpunit/includes/EntityModificationTestHelper.php index e597a02..f397fc7 100644 --- a/repo/tests/phpunit/includes/EntityModificationTestHelper.php +++ b/repo/tests/phpunit/includes/EntityModificationTestHelper.php @@ -2,11 +2,11 @@ namespace Wikibase\Test; +use PHPUnit_Framework_Assert as Assert; +use Wikibase\DataModel\Entity\Entity; use Wikibase\DataModel\Entity\EntityId; -use Wikibase\Entity; use Wikibase\Lib\Store\EntityRedirect; use Wikibase\Repo\WikibaseRepo; -use PHPUnit_Framework_Assert as Assert; /** * EntityModificationTestHelper @@ -219,4 +219,3 @@ } } - \ No newline at end of file diff --git a/repo/tests/phpunit/includes/api/RemoveReferencesTest.php b/repo/tests/phpunit/includes/api/RemoveReferencesTest.php index 56e8c91..2f87c46 100644 --- a/repo/tests/phpunit/includes/api/RemoveReferencesTest.php +++ b/repo/tests/phpunit/includes/api/RemoveReferencesTest.php @@ -4,7 +4,6 @@ use DataValues\StringValue; use UsageException; -use Wikibase\DataModel\Claim\Statement; use Wikibase\DataModel\Entity\Item; use Wikibase\DataModel\Reference; use Wikibase\DataModel\Snak\PropertyNoValueSnak; @@ -12,6 +11,7 @@ use Wikibase\DataModel\Snak\PropertyValueSnak; use Wikibase\DataModel\Snak\Snak; use Wikibase\DataModel\Snak\SnakList; +use Wikibase\DataModel\Statement\Statement; use Wikibase\Lib\ClaimGuidGenerator; use Wikibase\Repo\WikibaseRepo; -- To view, visit https://gerrit.wikimedia.org/r/165720 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10d7c3a81f2ce00d82e79a50f715c82a0211f3be Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: Addshore <addshorew...@gmail.com> Gerrit-Reviewer: Adrian Lang <adrian.l...@wikimedia.de> Gerrit-Reviewer: Hoo man <h...@online.de> Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits