jenkins-bot has submitted this change and it was merged.
Change subject: Replacing title attribute with mixin TitledElement
......................................................................
Replacing title attribute with mixin TitledElement
The title attribute for byte counter in MWSaveDialog is replaced with the mixin
TitledElement from label widget in OOUI
Change-Id: Ic4b37fac9e16b6db9091a16376e06d55bbb3d649
---
M modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
index 3677afd..e05ce80 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
@@ -338,7 +338,8 @@
this.editSummaryCountLabel = new OO.ui.LabelWidget ( {
$: this.$,
classes: [ 've-ui-mwSaveDialog-editSummary-count' ],
- label: String( this.editSummaryByteLimit )
+ label: String( this.editSummaryByteLimit ),
+ title: ve.msg( 'visualeditor-editsummary-bytes-remaining' )
} );
// Save panel
@@ -364,7 +365,6 @@
this.$saveOptions = this.$( '<div>' ).addClass(
've-ui-mwSaveDialog-options' ).append(
this.$( '<div>' ).addClass( 've-ui-mwSaveDialog-checkboxes' ),
this.editSummaryCountLabel.$element
- .attr( 'title', ve.msg(
'visualeditor-editsummary-bytes-remaining' ) )
);
this.$saveMessages = this.$( '<div>' );
this.$saveActions = this.$( '<div>' );
--
To view, visit https://gerrit.wikimedia.org/r/165912
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4b37fac9e16b6db9091a16376e06d55bbb3d649
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: SuchetaG <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
